fix(css): make sass types work with sass-embedded#18459
Merged
patak-cat merged 4 commits intovitejs:mainfrom Oct 25, 2024
Merged
fix(css): make sass types work with sass-embedded#18459patak-cat merged 4 commits intovitejs:mainfrom
patak-cat merged 4 commits intovitejs:mainfrom
Conversation
sapphi-red
commented
Oct 25, 2024
Comment on lines
+120
to
+130
| "packageExtensions": { | ||
| "sass-embedded": { | ||
| "peerDependencies": { | ||
| "source-map-js": "*" | ||
| }, | ||
| "peerDependenciesMeta": { | ||
| "source-map-js": { | ||
| "optional": true | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
This was needed to make the type-check happy.
Comment on lines
+14
to
+15
| // https://github.com/type-challenges/type-challenges/issues/29285 | ||
| type IsAny<T> = boolean extends (T extends never ? true : false) ? true : false |
Member
Author
There was a problem hiding this comment.
Interestingly, the mosted 👍 ed answer (type-challenges/type-challenges#232) didn't work in our case.
bluwy
approved these changes
Oct 25, 2024
Member
bluwy
left a comment
There was a problem hiding this comment.
Thanks for polishing up the types!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Built on top of #18458The types did not work when
sass-embeddedwas installed instead ofsass.