Skip to content

fix!: put manifest files in .vite directory by default#14230

Merged
sapphi-red merged 2 commits intovitejs:mainfrom
sapphi-red:feat/manifest-dot-vite-dir
Sep 18, 2023
Merged

fix!: put manifest files in .vite directory by default#14230
sapphi-red merged 2 commits intovitejs:mainfrom
sapphi-red:feat/manifest-dot-vite-dir

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 29, 2023

Description

Changes the default output path of manifest/ssrManifest to .vite/manifest.json/.vite/ssr-manifest.json.

fixes #9636

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) breaking change labels Aug 29, 2023
@sapphi-red sapphi-red added this to the 5.0 milestone Aug 29, 2023
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Aug 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red
Copy link
Member Author

sapphi-red commented Sep 14, 2023

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Sep 14, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
analogjs ✅ success
astro ✅ success
histoire ❌ failure
ladle ❌ failure
laravel ✅ success
marko ✅ success
nuxt ❌ failure
nx ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ❌ failure
sveltekit ✅ success
unocss ✅ success
vite-plugin-pwa ✅ success
vite-plugin-ssr ❌ failure
vite-plugin-react ✅ success
vite-plugin-react-pages ❌ failure
vite-plugin-react-swc ✅ success
vite-plugin-svelte ❌ failure
vite-plugin-vue ❌ failure
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success

@sapphi-red sapphi-red mentioned this pull request Sep 16, 2023
Merged
9 tasks
@sapphi-red sapphi-red requested a review from bluwy September 16, 2023 14:09
@sapphi-red sapphi-red merged commit 74fa024 into vitejs:main Sep 18, 2023
@sapphi-red sapphi-red deleted the feat/manifest-dot-vite-dir branch September 18, 2023 08:41
@danielroe danielroe mentioned this pull request Sep 18, 2023
Merged
8 tasks
@dominikg dominikg mentioned this pull request Sep 18, 2023
Merged
@Brain2000
Copy link

Brain2000 commented Nov 16, 2023

This just broke our build where the vite manifest was expected to be in the root folder, and we are still on 4.3.3. Weird...

@Brain2000
Copy link

Brain2000 commented Nov 16, 2023 •
edited
Loading

It looks like pnpm dlx isn't using the package.json file for vite, so somehow it is using version 5.0.0 instead of 4.3.3....
npx vite shows version 4.3.3
pnpm dlx vite shows version 5.0.0

At least now I know where this is coming from...

tsnobip added a commit to tsnobip/rescript-relay-router that referenced this pull request Jan 17, 2024
@tsnobip
change manifest.json path for vite 5.0
383b8fc 
manifest.json default path got moved into a .vite folder
cf vitejs/vite#14230
@tsnobip tsnobip mentioned this pull request Jan 17, 2024
Closed
@gcaraciolo
Copy link

gcaraciolo commented Jan 17, 2024

this pr introduces a bug in inertia-laravel in production. https://github.com/inertiajs/inertia-laravel

Inertia expects manifest.json to be at public/build. a quick fix was to provide this path in vite.config

@bluwy
Copy link
Member

bluwy commented Jan 18, 2024

@gcaraciolo you should report the issue to the repo. This is an intended breaking change in Vite 5.

@tenkiller tenkiller mentioned this pull request Apr 15, 2024
Merged
@tenkiller tenkiller mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

@bluwy bluwy bluwy approved these changes

Assignees

No one assigned

Labels

breaking change p2-edge-case Bug, but has workaround or limited in scope (priority)

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

manifest.json file collision

5 participants

@sapphi-red @Brain2000 @gcaraciolo @bluwy @patak-cat