Skip to content

fix(proxy): forward SSE close event#13578

Merged
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/proxy-sse-close
Jun 21, 2023
Merged

fix(proxy): forward SSE close event#13578
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/proxy-sse-close

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

See #13522 for more details.

fixes #13522

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jun 21, 2023
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-cat patak-cat enabled auto-merge (squash) June 21, 2023 08:08
@patak-cat patak-cat merged commit 4afbccb into vitejs:main Jun 21, 2023
@sapphi-red sapphi-red deleted the fix/proxy-sse-close branch June 21, 2023 08:16
xinxinhe1810 pushed a commit to xinxinhe1810/vite that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSE close event is not being forwarded to the server when using Vite as Reverse Proxy

2 participants