fix: remove deprecated config.server.base#13482
Merged
patak-cat merged 1 commit intovitejs:mainfrom Jun 12, 2023
Merged
Conversation
|
|
bluwy
approved these changes
Jun 11, 2023
Member
bluwy
left a comment
There was a problem hiding this comment.
Never noticed there's this option before. Looks like a good change to me and doesn't seem to break things.
sapphi-red
approved these changes
Jun 11, 2023
Member
sapphi-red
left a comment
There was a problem hiding this comment.
I read the changes of #7289. It seems the PR added server.base to the types and the docs, but the PR didn't use that anywhere.
patak-cat
approved these changes
Jun 12, 2023
9 tasks
brc-dd
added a commit
to vuejs/vitepress
that referenced
this pull request
Jun 13, 2023
1 task
SeniorKyrylo
pushed a commit
to SeniorKyrylo/VitePress-Vue.js
that referenced
this pull request
Aug 11, 2023
jasonreyes9
added a commit
to jasonreyes9/vitepress-vuejs
that referenced
this pull request
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I randomly found
server.base(https://vitejs.dev/config/server-options.html#server-base), but it seems like it is not being used anymore. The code was introduced in this pull request (before vite2 was released), but it appears to have not been invoked after a long period of code iteration. The documentation was introduced in this pull request. I suppose the rootbaseconfig has supersededserver.basenow.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).