feat: support BROWSER and BROWSER_ARGS in env file#11513
Merged
Conversation
sapphi-red
approved these changes
Dec 31, 2022
Member
sapphi-red
left a comment
There was a problem hiding this comment.
I tested this on Windows and worked fine 💯
patak-cat
approved these changes
Jan 3, 2023
Member
patak-cat
left a comment
There was a problem hiding this comment.
Awesome! I think this is an uncontroversial addition. Let's merge it for the 4.1 beta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #7329
close #9557
Support passing browser args through
process.env.BROWSER_ARGS, similar to CRA.Support
BROWSERandBROWSER_ARGSconfiguration in.envfiles as convenience. This could be a breaking change for users who set this for some specific configuration, but I don't think there's a significant impact in practice.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).