fix(css): fix stale css when reloading with hmr disabled (#10270)#11506
Merged
patak-cat merged 1 commit intovitejs:mainfrom Jan 4, 2023
Merged
fix(css): fix stale css when reloading with hmr disabled (#10270)#11506patak-cat merged 1 commit intovitejs:mainfrom
patak-cat merged 1 commit intovitejs:mainfrom
Conversation
In the non-hmr path, when invalidating a module, it wasn't invalidating the importers. This meant that CSS dynamically generated based on a module's contents (e.g., what tailwind does) would not regenerate when refreshing a page. The HMR code path already invalidated importers, which is why the bug didn't exist with HMR enabled. This change makes the invalidation consistent between HMR and non-HMR.
7 tasks
sapphi-red
approved these changes
Jan 1, 2023
Member
sapphi-red
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I'm not too sure, but the code looks good to me.
Also I tested this PR with a simple vue project and it worked with both hmr: true and hmr: false.
patak-cat
approved these changes
Jan 3, 2023
Member
patak-cat
left a comment
There was a problem hiding this comment.
Looks good to me too. Let's merge it in the 4.1 beta next week to be safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10270.
In the non-hmr code path, when invalidating a module, it wasn't invalidating the importers. This meant that CSS dynamically generated based on a module's contents (e.g., what tailwind does) would not regenerate when refreshing a page.
The HMR code path already invalidated importers, which is why the bug didn't exist with HMR enabled. This change makes the invalidation consistent between HMR and non-HMR.
The changes are quite minimal -- it's just merging some of the logic from the
invalidatefunction (in hmr.ts) into theinvalidateModulefunction (in moduleGraph.ts) and updating the call site.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).