Skip to content

fix: respect base when using /__open-in-editor#11337

Merged
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/open-in-editor-base
Dec 12, 2022
Merged

fix: respect base when using /__open-in-editor#11337
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/open-in-editor-base

Conversation

@sapphi-red
Copy link
Member

Description

fixes #8627

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 12, 2022
@patak-cat patak-cat merged commit 8856c2e into vitejs:main Dec 12, 2022
@sapphi-red sapphi-red deleted the fix/open-in-editor-base branch December 13, 2022 11:43
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fetch('/__open-in-editor') in error overlay does not respect base

2 participants