Conversation
sapphi-red
reviewed
Dec 11, 2022
f2f4e6f to
91df516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the beginning didn't like the red line in my editor for
cli.spec.ts.So I added a ts check.
Then I saw that
build.config.tswas not in the config.Then I got type issues with
rollupLicensePlugin.mjs, that I converted to TSThen I got issue with using import.meta in a cjs project, so I moved it to
vitepackage which is more appropriate IMO and closer to the main importer.Then I saw that this small project was not strict, which I enabled, but keeping the PR safe so I only added
!assertions and didn't touch runtime behaviour.Then I saw that
src/node/__test__andscriptswere also not covered, so I added them topackages/vite/tsconfig.json