Skip to content

fix: skip shortcuts on non-tty stdin#11263

Merged
patak-cat merged 1 commit intomainfrom
fix-shortcuts-tty
Dec 8, 2022
Merged

fix: skip shortcuts on non-tty stdin#11263
patak-cat merged 1 commit intomainfrom
fix-shortcuts-tty

Conversation

@ArnaudBarre
Copy link
Member

Fixes #11262

I've also added a CI check like we do in another places.

@ArnaudBarre ArnaudBarre self-assigned this Dec 8, 2022
@patak-cat
Copy link
Member

Thanks for the quick fix!

@patak-cat patak-cat merged commit 9602686 into main Dec 8, 2022
@patak-cat patak-cat deleted the fix-shortcuts-tty branch December 8, 2022 14:37
@sapphi-red
Copy link
Member

/ecosystem-ci run vite-setup-catalogue

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Dec 8, 2022

📝 Ran ecosystem CI: Open

suite result
vite-setup-catalogue ❌ failure

@patak-cat
Copy link
Member

Uh, sorry if I merged the PR too fast 🤔

@sapphi-red
Copy link
Member

The error happened because the branch was deleted. Nvm. I'll run against the main branch 👍

Uh, sorry if I merged the PR too fast 🤔

I just wanted to confirm it. No problem 😃

@sapphi-red
Copy link
Member

It worked 💯
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3649345447/jobs/6163894052

futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vite doesn't work without tty

3 participants