chore: add \0 to virtual files id#11261
Merged
patak-cat merged 3 commits intovitejs:mainfrom Dec 9, 2022
Merged
Conversation
sapphi-red
commented
Dec 8, 2022
Comment on lines
16
to
+17
| if (id === modulePreloadPolyfillId) { | ||
| return id | ||
| return resolvedModulePreloadPolyfillId |
Member
Author
There was a problem hiding this comment.
bluwy
approved these changes
Dec 9, 2022
patak-cat
approved these changes
Dec 9, 2022
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Member
|
@sapphi-red we may need to wait until the next minor for this one |
Member
Author
|
@patak-dev I think it's slightly safer to include this in 4.0. But I'm ok with delaying this until 4.1. |
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Member
|
You're right, it was just the base commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the resolvedId doesn't start with
\0, that parent directory will be watched by rollup.This PR changes the id and resolvedId for virtual files to avoid that.
fixes #10096
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).