Closed
Conversation
9 tasks
Contributor
Author
|
see #11245 for this without cancel. |
Collaborator
|
I filed a feature request: evanw/esbuild#2725 |
Collaborator
|
@dominikg perhaps you'd be able to rebase this PR?
|
Contributor
|
I wonder if this might help solve #9986. That sure would be nice! It's a big frustration for a lot of Storybook-vite users. |
Contributor
Author
|
not sure if rebase is a good idea, this PR has extra complexity that's no longer needed with the new esbuild api. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scanning currently starts multiple esbuild promises and there is no way to cancel them.
use a single pass promise and add a plugin that cancels the running build when calling
cancel()Additional context
this may be useful to prevent parallel runs of the optimizer too, ideally there was a simpler way to cancel the esbuild promise but i didn't see it :/
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).