fix: import.meta.env and process.env undefined variable replacement (fix #8663)#10958
Merged
patak-cat merged 3 commits intovitejs:mainfrom Nov 28, 2022
Merged
fix: import.meta.env and process.env undefined variable replacement (fix #8663)#10958patak-cat merged 3 commits intovitejs:mainfrom
patak-cat merged 3 commits intovitejs:mainfrom
Conversation
7 tasks
patak-cat
approved these changes
Nov 28, 2022
patak-cat
pushed a commit
that referenced
this pull request
Dec 5, 2022
* fix: glob import parsing (#10949) (#11056) closes #10949 closes #11051 * fix: import.meta.env and process.env undefined variable replacement (fix #8663) (#10958) Co-authored-by: bluwy <bjornlu.dev@gmail.com> fix #8663 * fix(esbuild): handle inline sourcemap option (#11120) * fix(importGlob): preserve line count for sourcemap (#11122) * fix: Dev SSR dep optimization + respect optimizeDeps.include (#11123) * fix: reset global regex before match (#11132) * chore: fix test Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: julienv3 <julienv3@gmail.com> Co-authored-by: 翠 / green <green@sapphi.red>
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
vitejs#8663) (vitejs#10958) Co-authored-by: bluwy <bjornlu.dev@gmail.com> fix vitejs#8663
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Vite using the replacement for "import.meta.env" instead of the replacement for "import.meta.env." when replacing an undefined environment variable (and any other "."-ending replacement never being used)
fix #8663
Additional context
Code:
import.meta.env.UNDEFINEDExpected replacement:
({}).UNDEFINEDActual replacement:
{"BASE_URL":"/","MODE":"production","DEV":false,"PROD":true}.UNDEFINEDNote that the above is inlining the full list of known env variables but also creating invalid JavaScript in some scenarios.
Issue originally reported at #8663
Additional broken build repro:
https://stackblitz.com/edit/vitejs-vite-bthpb6?file=main.js&terminal=build
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).