feat(hmr): invalidate message#10946
Merged
patak-cat merged 2 commits intovitejs:mainfrom Nov 17, 2022
ArnaudBarre:hmr-invalidate-reason
Merged
feat(hmr): invalidate message#10946patak-cat merged 2 commits intovitejs:mainfrom ArnaudBarre:hmr-invalidate-reason
patak-cat merged 2 commits intovitejs:mainfrom
ArnaudBarre:hmr-invalidate-reason
Conversation
patak-cat
reviewed
Nov 16, 2022
patak-cat
reviewed
Nov 17, 2022
patak-cat
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be helpful for building hmr invalidation for vite-plugin-swc-react-refresh. WIP on this branch
Should we always add a console log?
In this first implementation, I'm always skipping
clearfor the next hmr log so that's more visible that two updates happened.cc @IanVS @patak-dev
Note: After looking closer at the metro implementation, I found that I would need to get access to the previous module in the accept callback to get a complete implementation for refresh boundary check.