Thanks for splitting the PR!

It would be nice if we could have a better error message for #6858.
TypeError: Cannot read properties of undefined (reading 'split') is quite difficult to understand.
#6858 (comment)

@sapphi-red I'm trying to fix TypeError: Cannot read properties of undefined (reading 'split') if you have a better way to fix it, please come to motdotla/dotenv-expand#85 and give me some suggestions. Thanks!

It would be nice if we could have a better error message for #6858.
TypeError: Cannot read properties of undefined (reading 'split') is quite difficult to understand.
#6858 (comment)

Unless we have a hardcoded error check for the split undefined bug, I think it would be nicer if it's fixed upstream 🤔

Unless we have a hardcoded error check for the split undefined bug, I think it would be nicer if it's fixed upstream 🤔

Can we re-implement dotenv-expand in vite?

I think it's better to keep it upstream for now so it gets bug fixes and we can refer to its docs.

Unless we have a hardcoded error check for the split undefined bug, I think it would be nicer if it's fixed upstream 🤔

Yeah, I think it would be better to be fixed in upstream. But until that get fixed, I think we should improve the error message on our side. Something like:

try {
  expand()
} catch (e) {
  if (e.message.includes('split') {
    throw new Error('dotenv-expand failed to expand env vars. Maybe you need to escape `$`?')
  }
  throw e
}

Without that, I suppose we'll receive many bug reports.

I'd be fine with a custom error check for now too 👍

Let's merge and improve the error message in a follow-up PR. Let us know if you want to take that @Dunqing. I want to include this already in the next patch.

@Dunqing Just to confirm, do you plan to take the error one? I'll take that if you don't.

@Dunqing Just to confirm, do you plan to take the error one? I'll take that if you don't.

Sorry, I'll do that soon.

@Dunqing OK. No rush 👍🏼