fix: relocated logger to respect config.#10787
Merged
patak-cat merged 2 commits intovitejs:mainfrom Nov 7, 2022
qodesmith:clearscreen-option-fix
Merged
fix: relocated logger to respect config.#10787patak-cat merged 2 commits intovitejs:mainfrom qodesmith:clearscreen-option-fix
patak-cat merged 2 commits intovitejs:mainfrom
qodesmith:clearscreen-option-fix
Conversation
7 tasks
patak-cat
approved these changes
Nov 7, 2022
jeffydc
approved these changes
Nov 7, 2022
|
Can this maybe be added to Vite 3 as well? It's a major bug. |
Member
|
Feel free to cherry pick this and send a PR merging into the v3 branch |
|
@bluwy done :) |
patak-cat
pushed a commit
that referenced
this pull request
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simply moves the location of where the logger is created further down in the code. This fixes #10780.
Additional context
The logger was being instantiated too early and wasn't respecting potential changes to the
clearScreenconfig option that could have been changed via plugins. Now that the logger is instantiated after plugins are processed, it will pick up changes in the config correctly.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).