Skip to content

fix(config): partial deno support#10446

Merged
patak-cat merged 2 commits intomainfrom
partial-deno-support
Oct 13, 2022
Merged

fix(config): partial deno support#10446
patak-cat merged 2 commits intomainfrom
partial-deno-support

Conversation

@bluwy
Copy link
Member

@bluwy bluwy commented Oct 12, 2022

Description

#10254 uses tryNodeResolve trips Deno npm:* imports in WIndows.

Fixes bluwy/create-vite-extra#9

"Partial" as we don't support npm: in Vite apps, but only in Vite config (we may want to wait out for this to be a convention, or when Deno stabilizes)

Additional context

Thanks @mathe42 for digging into the bug!

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Oct 12, 2022
mathe42
mathe42 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@mathe42 mathe42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by changing the dist code in node_modules and it fixes the bug.

@patak-cat patak-cat merged commit c4489ea into main Oct 13, 2022
@patak-cat patak-cat deleted the partial-deno-support branch October 13, 2022 07:37
@patak-cat patak-cat added this to the 3.2 milestone Oct 13, 2022
@mathe42 mathe42 mentioned this pull request Oct 13, 2022
Closed
bluwy added a commit that referenced this pull request Oct 13, 2022
@bluwy
fix(config): partial deno support (#10446)
2290610
@bluwy bluwy mentioned this pull request Oct 13, 2022
Merged
patak-cat pushed a commit that referenced this pull request Oct 13, 2022
@bluwy
fix(config): support builtin modules and deno (#10457)
8fbae69 
* fix(config): skip resolve builtin modules (#10420)

* fix(config): partial deno support (#10446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

+1 more reviewer

@mathe42 mathe42 mathe42 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

bug: [plugin externalize-deps] EINVAL: invalid argument, stat

3 participants

@bluwy @patak-cat @mathe42