Skip to content

fix(hmr): handle virtual module update#10324

Merged
patak-cat merged 1 commit intomainfrom
fix-virtual-hmr
Oct 3, 2022
Merged

fix(hmr): handle virtual module update#10324
patak-cat merged 1 commit intomainfrom
fix-virtual-hmr

Conversation

@bluwy
Copy link
Member

@bluwy bluwy commented Oct 3, 2022

Description

Alternative to #10313
Should also fix #6871 but I'm not sure how to test it

This PR ensures HMR urls are properly wrapped before sending to the HMR client.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: hmr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Oct 3, 2022
patak-cat
patak-cat approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@patak-cat patak-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was going to propose the same in the other PR.

@patak-cat
Copy link
Member

patak-cat commented Oct 3, 2022

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 3, 2022 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
iles ✅ success
ladle ❌ failure
laravel ❌ failure
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
storybook ❌ failure
svelte ✅ success
vite-plugin-ssr ❌ failure
vite-setup-catalogue ✅ success
vitepress ❌ failure
vitest ❌ failure
windicss ✅ success

@patak-cat patak-cat mentioned this pull request Oct 3, 2022
Closed
9 tasks
@patak-cat
Copy link
Member

patak-cat commented Oct 3, 2022

The failures in ecosystem-ci seem related to the current issues in the 3.2 ci (most of them are problems with the project's CIs).
Let's merge this one for 3.2. @bluwy maybe you could backport this in a PR to v3.1 and we can run /ecosystem-ci run there too? We need to work with maintainers to get back to a green state for ecosystem ci, it is quite hard to use it with so many false positives (dominikg is also working on an update that will run the project's CI without overrides after a fail so we can mark results as invalid instead of a fail)

@patak-cat patak-cat merged commit 7c4accb into main Oct 3, 2022
@patak-cat patak-cat deleted the fix-virtual-hmr branch October 3, 2022 09:14
@bluwy bluwy mentioned this pull request Oct 3, 2022
Closed
4 tasks
antfu pushed a commit that referenced this pull request Oct 6, 2022
@bluwy @antfu
fix(hmr): handle virtual module update (#10324)
14ebbc6
@tobiasdiez tobiasdiez mentioned this pull request Oct 26, 2022
Closed
@bluwy bluwy mentioned this pull request May 8, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

@antfu antfu antfu approved these changes

Assignees

No one assigned

Labels

feat: hmr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reload virtual module on demand

3 participants

@bluwy @patak-cat @antfu