Support mask for XfrmState's output mark#602
Merged
aboch merged 1 commit intovishvananda:masterfrom Dec 30, 2020
Merged
Conversation
386e5e9 to
b600385
Compare
aboch
reviewed
Dec 28, 2020
Collaborator
aboch
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
A couple of minor comments.
XfrmState currently doesn't allow setting the mask for the output mark. As a result, setting an output mark always clears all bits. This commit adds support for the mask value. Signed-off-by: Paul Chaignon <paul@cilium.io>
b600385 to
ffddbfd
Compare
Contributor
Author
|
@aboch Thanks for the review! I removed the two unnecessary type convertions. |
Collaborator
|
LGTM |
pchaigno
added a commit
to cilium/cilium
that referenced
this pull request
Jan 4, 2021
Pull the latest version of our netlink lib dependency, which includes support for setting the mask of XfrmState's output marks [1]. 1 - vishvananda/netlink#602 Signed-off-by: Paul Chaignon <paul@cilium.io>
aditighag
pushed a commit
to cilium/cilium
that referenced
this pull request
Jan 4, 2021
Pull the latest version of our netlink lib dependency, which includes support for setting the mask of XfrmState's output marks [1]. 1 - vishvananda/netlink#602 Signed-off-by: Paul Chaignon <paul@cilium.io>
christarazi
pushed a commit
to cilium/cilium
that referenced
this pull request
Jan 6, 2021
[ upstream commit 1f91c0f ] Pull the latest version of our netlink lib dependency, which includes support for setting the mask of XfrmState's output marks [1]. 1 - vishvananda/netlink#602 Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
pushed a commit
to cilium/cilium
that referenced
this pull request
Jan 6, 2021
[ upstream commit 1f91c0f ] Pull the latest version of our netlink lib dependency, which includes support for setting the mask of XfrmState's output marks [1]. 1 - vishvananda/netlink#602 Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
pushed a commit
to cilium/cilium
that referenced
this pull request
Jan 8, 2021
[ upstream commit 1f91c0f ] Pull the latest version of our netlink lib dependency, which includes support for setting the mask of XfrmState's output marks [1]. 1 - vishvananda/netlink#602 Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
joestringer
pushed a commit
to cilium/cilium
that referenced
this pull request
Jan 13, 2021
[ upstream commit 1f91c0f ] Pull the latest version of our netlink lib dependency, which includes support for setting the mask of XfrmState's output marks [1]. 1 - vishvananda/netlink#602 Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
pushed a commit
to cilium/cilium
that referenced
this pull request
Jan 13, 2021
[ upstream commit 1f91c0f ] Pull the latest version of our netlink lib dependency, which includes support for setting the mask of XfrmState's output marks [1]. 1 - vishvananda/netlink#602 Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
gandro
pushed a commit
to cilium/cilium
that referenced
this pull request
Jan 14, 2021
[ upstream commit 1f91c0f ] Pull the latest version of our netlink lib dependency, which includes support for setting the mask of XfrmState's output marks [1]. 1 - vishvananda/netlink#602 Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XfrmState currently doesn't allow setting the mask for the output mark. As a result, setting an output mark always clears all bits. This pull request adds support for the mask value.