Merged
Conversation
Currently, it's cumbersome to get a link by an IP addr - one needs to list all links and then call AddrList() for each of them. Considering that ifindex is already available to to the parseAddr() helper function, we can expose it to a user via the newly added Addr.LinkIndex field. This makes the retrieving link by IP addr much more simple. Signed-off-by: Martynas Pumputis <m@lambda.lt>
Contributor
Author
brb
added a commit
to cilium/cilium
that referenced
this pull request
Jun 3, 2020
Until vishvananda/netlink#543 has been merged, use Cilium's fork. Signed-off-by: Martynas Pumputis <m@lambda.lt>
Collaborator
|
LGTM |
Contributor
Author
|
@aboch Thanks! |
brb
added a commit
to cilium/cilium
that referenced
this pull request
Jun 4, 2020
Pull the latest version which includes a new field LinkIndex in Addr struct [1]. This is going to be used for retrieving link by ip addr. [1]: vishvananda/netlink#543 Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added a commit
to cilium/cilium
that referenced
this pull request
Jun 5, 2020
Pull the latest version which includes a new field LinkIndex in Addr struct [1]. This is going to be used for retrieving link by ip addr. [1]: vishvananda/netlink#543 Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added a commit
to cilium/cilium
that referenced
this pull request
Jun 8, 2020
Pull the latest version which includes a new field LinkIndex in Addr struct [1]. This is going to be used for retrieving link by ip addr. [1]: vishvananda/netlink#543 Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added a commit
to cilium/cilium
that referenced
this pull request
Jun 10, 2020
Pull the latest version which includes a new field LinkIndex in Addr struct [1]. This is going to be used for retrieving link by ip addr. [1]: vishvananda/netlink#543 Signed-off-by: Martynas Pumputis <m@lambda.lt>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 11, 2020
Pull the latest version which includes a new field LinkIndex in Addr struct [1]. This is going to be used for retrieving link by ip addr. [1]: vishvananda/netlink#543 Signed-off-by: Martynas Pumputis <m@lambda.lt>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 11, 2020
[ upstream commit 2cd23fe ] Pull the latest version which includes a new field LinkIndex in Addr struct [1]. This is going to be used for retrieving link by ip addr. [1]: vishvananda/netlink#543 Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: André Martins <andre@cilium.io>
joestringer
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 12, 2020
[ upstream commit 2cd23fe ] Pull the latest version which includes a new field LinkIndex in Addr struct [1]. This is going to be used for retrieving link by ip addr. [1]: vishvananda/netlink#543 Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: André Martins <andre@cilium.io>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it's cumbersome to get a link by an IP addr - one needs to list all links and then call
AddrList()for each of them.Considering that ifindex is already available to to the
parseAddr()helper function, we can expose it to a user via the newly addedAddr.LinkIndexfield. This makes the retrieving link by IP addr much more simple.