Fix parseIpTun to handle empty flow based flag#512
Merged
fcrisciani merged 1 commit intomasterfrom Jan 27, 2020
Merged
Conversation
jellonek
approved these changes
Jan 18, 2020
Contributor
jellonek
left a comment
There was a problem hiding this comment.
IMO this requires also a followup with test coverage but still - LGTM
Collaborator
|
LGTM, will submit considering that avoid a crash. |
gkodali-zededa
pushed a commit
to gkodali-zededa/netlink
that referenced
this pull request
May 21, 2021
The first fix vishvananda#512 apparently didn't solve all cases. This generically skips values that are null to solve the problem. Also closes vishvananda#548.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #509