fix(geo-layers) Refactor GeohashLayerProps to extend GeoCellLayerProps#9875
Merged
chrisgervang merged 2 commits intomasterfrom Dec 1, 2025
Merged
fix(geo-layers) Refactor GeohashLayerProps to extend GeoCellLayerProps#9875chrisgervang merged 2 commits intomasterfrom
chrisgervang merged 2 commits intomasterfrom
Conversation
GeohashLayerProps now extends GeoCellLayerProps for better type composition and reusability. The class definition and type usage have been updated to reflect this change.
felixpalmer
approved these changes
Nov 28, 2025
felixpalmer
pushed a commit
that referenced
this pull request
Dec 3, 2025
GeohashLayerProps now extends GeoCellLayerProps for better type composition and reusability. The class definition and type usage have been updated to reflect this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9854
Background
The
GeohashLayerPropstype definition was missing the polygon layer properties. This update follows the same pattern asQuadkeyLayerandS2Layer_GeohashLayerProps<DataT>for layer-specific propertiesGeohashLayerProps<DataT>to merge_GeohashLayerProps<DataT> & GeoCellLayerProps<DataT>PolygonLayerProps(sinceGeoCellLayerPropsis an alias forPolygonLayerProps)Required<GeohashLayerProps>toRequired<_GeohashLayerProps<DataT>>Change List
Note
Refactors GeohashLayer typing to compose
_GeohashLayerPropswithGeoCellLayerPropsand updates class generics accordingly.GeohashLayerProps<DataT>now composes_GeohashLayerProps<DataT> & GeoCellLayerProps<DataT>._GeohashLayerProps<DataT>for layer-specific props (getGeohash).Required<GeohashLayerProps>toRequired<_GeohashLayerProps<DataT>>.GeoCellLayerPropsimport and updates doc comments.Written by Cursor Bugbot for commit a1821c5. This will update automatically on new commits. Configure here.