Skip to content

Fix orthographic scroll zoom transitions#9769

Merged
Pessimistress merged 2 commits intomasterfrom
codex/fix-scroll-zoom-bug-in-orthographiccontroller
Sep 15, 2025
Merged

Fix orthographic scroll zoom transitions#9769
Pessimistress merged 2 commits intomasterfrom
codex/fix-scroll-zoom-bug-in-orthographiccontroller

Conversation

@ibgreen-openai
Copy link
Collaborator

@ibgreen-openai ibgreen-openai commented Sep 9, 2025

Summary

  • setting scrollZoom: {smooth: false} did not completely disable transitions, which made it impossible to avoid transition related issues.
  • avoid triggering zero-duration transitions when handling scroll zoom events to stop orthographic views from snapping back while rendering is slow
  • add a regression test that ensures scroll wheel zoom immediately updates the orthographic view state when smooth scrolling is disabled

Testing

  • yarn test node test/modules/core/controllers/controllers.spec.ts

https://chatgpt.com/codex/tasks/task_i_68c031d9faf4832ca611a08cb85db61a

@coveralls
Copy link

coveralls commented Sep 9, 2025

Coverage Status

coverage: 91.18% (-0.001%) from 91.181%
when pulling f044aea on codex/fix-scroll-zoom-bug-in-orthographiccontroller
into d5d3f72 on master.

@Pessimistress Pessimistress merged commit 107de2e into master Sep 15, 2025
5 checks passed
@Pessimistress Pessimistress deleted the codex/fix-scroll-zoom-bug-in-orthographiccontroller branch September 15, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants