feat(layers) Tighten layer prop types#10024
Merged
Pessimistress merged 1 commit intomasterfrom Feb 20, 2026
Merged
Conversation
chrisgervang
approved these changes
Feb 20, 2026
Collaborator
chrisgervang
left a comment
There was a problem hiding this comment.
This seems like a good idea. Is there any world where an extension mutates a users prop? I suppose that'd be rare and they could cast to unknown first to workaround it
Collaborator
Author
|
@chrisgervang on principal we should not mutate user input. When we process user data we always make a copy of it. |
Pessimistress
added a commit
that referenced
this pull request
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In the current release, when supplying a constant array to a layer prop such as
*Color, you get the following type error:In reality, our layers do not mutate user-supplied data. This PR marks all layer props that expect array values as
readonly. It will continue to work with dynamically constructed values, but also accept constants.Change list
ColorandPositiontypesreadonlyreadonly, e.g. normals, scales, domainsoutlineColor