Skip to content

config_entry assignation is deprecated#79

Merged
virtualdj merged 3 commits into
virtualdj:masterfrom
Daemo00:deprecated_config_entry_assignation
Jan 18, 2025
Merged

config_entry assignation is deprecated#79
virtualdj merged 3 commits into
virtualdj:masterfrom
Daemo00:deprecated_config_entry_assignation

Conversation

@Daemo00

@Daemo00 Daemo00 commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

Fix #78.

@Daemo00 Daemo00 marked this pull request as ready for review January 12, 2025 21:37
@virtualdj

virtualdj commented Jan 13, 2025

Copy link
Copy Markdown
Owner

Grazie, però vorrei poter gestire anche le versioni precedenti. La modifica fatta così com'è sarebbe compatibile solo da HA 2024.12 in poi, sulle altre invece:

ConfigFlow error

2025-01-13 18:28:00.936 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
  File "/srv/ha4/lib/python3.11/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/components/http/security_filter.py", line 85, in security_filter_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/components/http/ban.py", line 80, in ban_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/components/http/auth.py", line 236, in auth_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/components/http/headers.py", line 31, in headers_middleware
    response = await handler(request)
               ^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/components/http/view.py", line 148, in handle
    result = await handler(request, **request.match_info)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/components/http/decorators.py", line 63, in with_admin
    return await func(self, request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/components/config/config_entries.py", line 213, in post
    return await super().post(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/components/http/data_validator.py", line 72, in wrapper
    result = await method(view, request, data, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/helpers/data_entry_flow.py", line 71, in post
    result = await self._flow_mgr.async_init(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/data_entry_flow.py", line 270, in async_init
    result = await self._async_handle_step(flow, flow.init_step, data)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/ha4/lib/python3.11/site-packages/homeassistant/data_entry_flow.py", line 394, in _async_handle_step
    result: FlowResult = await getattr(flow, method)(user_input)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/homeassistant/.homeassistant/custom_components/pun_sensor/config_flow.py", line 42, in async_step_init
    default=self.config_entry.options.get(
            ^^^^^^^^^^^^^^^^^
AttributeError: 'PUNOptionsFlow' object has no attribute 'config_entry'

@virtualdj virtualdj added bug Something isn't working minor New minor version labels Jan 13, 2025
virtualdj
virtualdj requested changes Jan 13, 2025
View reviewed changes
Comment thread custom_components/pun_sensor/config_flow.py Outdated
) -> PUNOptionsFlow:
"""Ottiene le opzioni per questa configurazione."""
return PUNOptionsFlow(config_entry)
return PUNOptionsFlow()

@virtualdj virtualdj Jan 13, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questo dovrebbe essere eseguito solo con versioni di Home Assistant >= 2024.12, mentre il vecchio codice negli altri casi (sperando che Home Assistant non si lamenti).

@Daemo00 Daemo00 Jan 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giusto, grazie, puoi vedere se ora va meglio?

@Daemo00 Daemo00 force-pushed the deprecated_config_entry_assignation branch from 9af437d to fcbd8a3 Compare January 16, 2025 12:06
@Daemo00 Daemo00 requested a review from virtualdj January 16, 2025 12:16
virtualdj
virtualdj requested changes Jan 16, 2025
View reviewed changes
Comment thread custom_components/pun_sensor/config_flow.py Outdated
) -> PUNOptionsFlow:
"""Ottiene le opzioni per questa configurazione."""
return PUNOptionsFlow(config_entry)
if AwesomeVersion(HA_VERSION) >= AwesomeVersion("2024.12.0b0"):

@virtualdj virtualdj Jan 16, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

È sufficiente "2024.12.0".

@Daemo00 Daemo00 Jan 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho messo anche la versione beta perché il commit home-assistant/core@6d561a9 è anche lì:
image
Dici che è un problema lasciarlo?

@virtualdj virtualdj Jan 16, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, ma dubito che qualcuno usi le beta "in produzione", perciò mi sembrava più pulito "2024.12.0".

@Daemo00 Daemo00 Jan 17, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certo, sono d'accordo che "2024.12.0" sarebbe più pulito ma non credo sarebbe corretto perché nella versione "2024.12.0b0" causerebbe l'errore che hai riportato in #79 (comment):

...
AttributeError: 'PUNOptionsFlow' object has no attribute 'config_entry'

Comment thread custom_components/pun_sensor/config_flow.py Outdated
@Daemo00 Daemo00 requested a review from virtualdj January 16, 2025 17:56
@Daemo00 Daemo00 force-pushed the deprecated_config_entry_assignation branch 2 times, most recently from edd5152 to a16d200 Compare January 17, 2025 10:30
@Daemo00 Daemo00 marked this pull request as draft January 17, 2025 10:37
@Daemo00 Daemo00 force-pushed the deprecated_config_entry_assignation branch from a16d200 to 78a3ddd Compare January 17, 2025 10:43
@Daemo00 Daemo00 marked this pull request as ready for review January 17, 2025 10:53
virtualdj
virtualdj requested changes Jan 17, 2025
View reviewed changes

@virtualdj virtualdj left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solo cambiamenti "cosmetici" ma mi piacerebbe di più così.

Comment thread custom_components/pun_sensor/config_flow.py Outdated
if AwesomeVersion(HA_VERSION) < AwesomeVersion("2024.12.0b0"):
options_flow = PUNOptionsFlow(config_entry)
else:
options_flow = PUNOptionsFlow()

@virtualdj virtualdj Jan 17, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puoi ritornare direttamente con return PUNOptionsFlow()?

@Daemo00 Daemo00 Jan 17, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certo, fatto.
Di solito cerco di mantenere un solo punto di uscita delle funzioni/metodi però è solo una mia preferenza 😄

Comment thread custom_components/pun_sensor/config_flow.py Outdated
"""Ottiene le opzioni per questa configurazione."""
return PUNOptionsFlow(config_entry)
if AwesomeVersion(HA_VERSION) < AwesomeVersion("2024.12.0b0"):
options_flow = PUNOptionsFlow(config_entry)

@virtualdj virtualdj Jan 17, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puoi ritornare direttamente con return PUNOptionsFlow(config_entry)?

@Daemo00
config_entry assignation is deprecated
77d589c 
Otherwise the following warning is raised:
Logger: homeassistant.helpers.frame
Source: helpers/frame.py:324
First occurred: January 11, 2025 at 23:29:37 (4 occurrences)
Last logged: 00:16:34

Detected that custom integration 'pun_sensor' sets option flow config_entry explicitly, which is deprecated at custom_components/pun_sensor/config_flow.py, line 33: self.config_entry = entry. This will stop working in Home Assistant 2025.12, please create a bug report at https://github.com/virtualdj/pun_sensor/issues

Deprecation happened in home-assistant/core@6d561a9
@Daemo00 Daemo00 force-pushed the deprecated_config_entry_assignation branch from 78a3ddd to 77d589c Compare January 17, 2025 17:28
@virtualdj

virtualdj commented Jan 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner

@Daemo00 Tra l'altro stavo cercando di aggiornare HACS all'ultima versione sul mio sistema di test e, tra le novità, ho trovato questa.

Pare che la modifica da fare sia ancora più semplice... prova a togliere tutto e cambiare solo:

pun_sensor/custom_components/pun_sensor/config_flow.py

Lines 31 to 33 in 433d107

def __init__(self, entry: config_entries.ConfigEntry) -> None:
"""Inizializzazione opzioni."""
self.config_entry = entry

in:

    def __init__(self, entry: config_entries.ConfigEntry) -> None:
        """Inizializzazione opzioni."""
        if AwesomeVersion(HA_VERSION) < AwesomeVersion("2024.12.0b0"):
            self.config_entry = entry

Dovrebbe funzionare ed è ancora più pulito! Modifica e prova sul tuo recente che io provo sul mio.

virtualdj added a commit that referenced this pull request Jan 18, 2025
@virtualdj @Daemo00
Annulla le modifiche e applica il fix più semplice
4ff3711 
Questa commit annulla le modifiche della PR #79 e applica un nuovo fix. Grazie a @Daemo00 per il contributo iniziale.
Co-authored-by: Simone Rubino <daemo00@gmail.com>
@virtualdj
Revert "config_entry assignation is deprecated"
c9f4e8e 
This reverts commit 77d589c to apply a different fix.
@virtualdj
Annulla le modifiche e applica il fix più semplice
21c49c2 
Questa commit annulla le modifiche della PR virtualdj#79 e applica un nuovo fix. Grazie a @Daemo00 per il contributo iniziale.
@virtualdj virtualdj merged commit cc90530 into virtualdj:master Jan 18, 2025
@Daemo00

Daemo00 commented Jan 19, 2025

Copy link
Copy Markdown
Contributor Author

@Daemo00 Tra l'altro stavo cercando di aggiornare HACS all'ultima versione sul mio sistema di test e, tra le novità, ho trovato questa.

Pare che la modifica da fare sia ancora più semplice... prova a togliere tutto e cambiare solo:

pun_sensor/custom_components/pun_sensor/config_flow.py

Lines 31 to 33 in 433d107

def __init__(self, entry: config_entries.ConfigEntry) -> None:
"""Inizializzazione opzioni."""
self.config_entry = entry

in:

    def __init__(self, entry: config_entries.ConfigEntry) -> None:
        """Inizializzazione opzioni."""
        if AwesomeVersion(HA_VERSION) < AwesomeVersion("2024.12.0b0"):
            self.config_entry = entry

Dovrebbe funzionare ed è ancora più pulito! Modifica e prova sul tuo recente che io provo sul mio.

Grazie che hai portato avanti il tutto, purtroppo questo weekend non ho potuto fare nulla.

@virtualdj

virtualdj commented Jan 19, 2025

Copy link
Copy Markdown
Owner

@Daemo00 Nessun problema, grazie a te!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virtualdj virtualdj virtualdj requested changes

Assignees

No one assigned

Labels

bug Something isn't working minor New minor version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sets option flow config_entry explicitly, which is deprecated

2 participants

@Daemo00 @virtualdj