Styling our code based on a new omnisharp config file#49
Merged
juniorxsound merged 5 commits intomasterfrom Feb 14, 2019
Merged
Styling our code based on a new omnisharp config file#49juniorxsound merged 5 commits intomasterfrom
juniorxsound merged 5 commits intomasterfrom
Conversation
caseypugh
suggested changes
Oct 25, 2018
Contributor
caseypugh
left a comment
There was a problem hiding this comment.
Let's put omnisharp.json into the working directory, not your root folder. That way you dont even need to set this up and it Just Works.
See https://github.com/OmniSharp/omnisharp-roslyn/wiki/Configuration-Options
At startup, OmniSharp obtains the configuration options using the following (hierarchical) order:
- its own hardcoded defaults
- Environment variables
- Command line arguments
- An omnisharp.json file located in %USERPROFILE%/.omnisharp/
- An omnisharp.json file located in the working directory which OmniSharp has been pointed at
caseypugh
approved these changes
Feb 14, 2019
juniorxsound
added a commit
that referenced
this pull request
Feb 14, 2019
Using this PR (#49) the current PR formats our code-base using the Omnisharp config file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Our code has different style conventions and as it grows, having a consistent style guide will help make it easier to read through and contribute to.
What changed
Reformatted the contents of
Vimeo/Scriptsusing our new styling configTested against:
Omnisharp formatting options options