fix wrong handling of flags in context#7195
Merged
orklah merged 3 commits intovimeo:masterfrom Dec 21, 2021
orklah:switch_weirdness
Merged
fix wrong handling of flags in context#7195orklah merged 3 commits intovimeo:masterfrom orklah:switch_weirdness
orklah merged 3 commits intovimeo:masterfrom
orklah:switch_weirdness
Conversation
Collaborator
Author
|
CI is failing for unrelated reason. I filed an issue here: thecodingmachine/docker-images-php#285 |
muglug
approved these changes
Dec 21, 2021
Collaborator
Author
|
Thanks for the review @muglug ;) |
Collaborator
|
I wonder if we could simplify this pattern with something like this: $context->withAlteredFlags(function (Context $context) use (...) {
$context->inside_conditional = false;
SomeAnalizer::analyze(..., $context);
});that would undo flag changes performed by the callback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started when I noticed a weird handling of inside_conditional flag in switch. After looking for more I found a few.
After that, I noticed that we don't always unflag those before leaving an analyzer, mainly when the other analyzer we called returned false.
Not sure this will have any effect whatsoever, but it may fix a few edge cases here and there. It will be less confusing in any case