[BUGFIX] Avoid crash during interface checks on non-existing classes#5984
Merged
muglug merged 1 commit intovimeo:masterfrom Jun 22, 2021
Merged
[BUGFIX] Avoid crash during interface checks on non-existing classes#5984muglug merged 1 commit intovimeo:masterfrom
muglug merged 1 commit intovimeo:masterfrom
Conversation
`ClassLikes::classImplements(NonExisting::class, WellKnown::class)` now returns `false` instead of throwing an exception for non-existing classes. Fixes: vimeo#5983
muglug
approved these changes
Jun 22, 2021
Collaborator
|
Thanks! |
ohader
added a commit
to ohader/psalm
that referenced
this pull request
Feb 20, 2024
Similar to the behavior of `ClassLikes::classImplements()` (vimeo#5984), the following methods will return a false/empty value in case a specific class name has not been initialized yet: + `ClassLikes::classExtends()` returns `false` + `ClassLikes::getParentInterfaces()` returns `[]`
ohader
added a commit
to ohader/psalm
that referenced
this pull request
Feb 20, 2024
Similar to the behavior of `ClassLikes::classImplements()` (vimeo#5984), the following methods will return a false/empty value in case a specific class name has not been initialized yet: + `ClassLikes::classExtends()` returns `false` + `ClassLikes::getParentInterfaces()` returns `[]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassLikes::classImplements(NonExisting::class, WellKnown::class)now returns
falseinstead of throwing an exception for non-existingclasses.
Fixes: #5983