ambiguous php version checks#4331
Merged
muglug merged 1 commit intovimeo:masterfrom Oct 15, 2020
orklah:php-ambiguous-version
Merged
ambiguous php version checks#4331muglug merged 1 commit intovimeo:masterfrom orklah:php-ambiguous-version
muglug merged 1 commit intovimeo:masterfrom
orklah:php-ambiguous-version
Conversation
weirdan
approved these changes
Oct 14, 2020
Collaborator
|
Thanks! |
muglug
pushed a commit
that referenced
this pull request
Oct 15, 2020
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix some case where the PHP version checks are ambiguous and could lead to regressions when the php_minor_version start from 0 again in PHP 8.0