Proposal: Support end_lnum (%e) and end_col (%k) with errorformat#9624
Closed
haya14busa wants to merge 1 commit intovim:masterfrom
Closed
Proposal: Support end_lnum (%e) and end_col (%k) with errorformat#9624haya14busa wants to merge 1 commit intovim:masterfrom
%e) and end_col (%k) with errorformat#9624haya14busa wants to merge 1 commit intovim:masterfrom
Conversation
Contributor
|
Isn't there an |
Contributor
|
Did anyone try this? Any comments? |
Codecov Report
@@ Coverage Diff @@
## master #9624 +/- ##
=======================================
Coverage 83.51% 83.51%
=======================================
Files 154 154
Lines 174602 174618 +16
Branches 39271 39276 +5
=======================================
+ Hits 145823 145839 +16
Misses 16675 16675
Partials 12104 12104
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yegappan
approved these changes
Feb 8, 2022
Member
yegappan
left a comment
There was a problem hiding this comment.
The changes looks good to me.
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Feb 9, 2022
…orformat' Problem: No support for end line number and column in 'errorformat'. Solution: Add %e and %k. (closes vim/vim#9624) vim/vim@e023d49
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Feb 9, 2022
…orformat' Problem: No support for end line number and column in 'errorformat'. Solution: Add %e and %k. (closes vim/vim#9624) vim/vim@e023d49 Use "\t" to represent a Tab as it looks better.
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Feb 9, 2022
…orformat' Problem: No support for end line number and column in 'errorformat'. Solution: Add %e and %k. (closes vim/vim#9624) vim/vim@e023d49 Use "\t" to represent a Tab as it looks better.
zbirenbaum
pushed a commit
to zbirenbaum/neovim
that referenced
this pull request
Feb 11, 2022
…orformat' Problem: No support for end line number and column in 'errorformat'. Solution: Add %e and %k. (closes vim/vim#9624) vim/vim@e023d49 Use "\t" to represent a Tab as it looks better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #8393, modern tools may be able to specify range when outputting the location of the source code.
While #8393 added end_lnum and end_col support to quickfix entry, errorformat did not support parsing end lnum/col. This PR added end_lnum (
%e) and end_col (%k) errorformat support.Example: gopls (Go Language Server) CLI interface support outputting locations with the following format.
Actual message example:
What do you think?