Add CursorLineSign and CursorLineFold highlight groups#9201
Closed
gpanders wants to merge 1 commit intovim:masterfrom
Closed
Add CursorLineSign and CursorLineFold highlight groups#9201gpanders wants to merge 1 commit intovim:masterfrom
gpanders wants to merge 1 commit intovim:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9201 +/- ##
==========================================
- Coverage 90.17% 88.44% -1.74%
==========================================
Files 151 150 -1
Lines 170849 167991 -2858
==========================================
- Hits 154070 148576 -5494
- Misses 16779 19415 +2636
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
|
Asan reports a couple of memory leaks, please fix that. |
a272e32 to
7d266b8
Compare
Contributor
Author
|
Forgot a |
Contributor
Author
|
These tests are failing: Not sure how or if that's related to these changes though. |
Member
|
looks like those currently also happen on master, so probably unrelated |
Contributor
|
Please sync to head, then the failures should be gone. |
These are similar to the SignColumn and FoldColumn groups but only take effect for the cursor line and when the 'cursorline' option is set.
7d266b8 to
ffa66bb
Compare
Contributor
Author
|
Done |
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 6, 2021
Problem: Cannot adjust sign highlighting for 'cursorline'.
Solution: Add CursorLineSign and CursorLineFold highlight groups.
(Gregory Anders, closes vim/vim#9201)
vim/vim@e413ea0
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 6, 2021
Problem: Cannot adjust sign highlighting for 'cursorline'.
Solution: Add CursorLineSign and CursorLineFold highlight groups.
(Gregory Anders, closes vim/vim#9201)
vim/vim@e413ea0
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 6, 2021
Problem: Cannot adjust sign highlighting for 'cursorline'.
Solution: Add CursorLineSign and CursorLineFold highlight groups.
(Gregory Anders, closes vim/vim#9201)
vim/vim@e413ea0
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 9, 2021
Problem: Cannot adjust sign highlighting for 'cursorline'.
Solution: Add CursorLineSign and CursorLineFold highlight groups.
(Gregory Anders, closes vim/vim#9201)
vim/vim@e413ea0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are similar to the SignColumn and FoldColumn groups but only take
effect for the cursor line and when the 'cursorline' option is set.