Skip to content

Add fuzzy matching support to the vimgrep command#8152

Closed
yegappan wants to merge 1 commit intovim:masterfrom
yegappan:vimgrep
Closed

Add fuzzy matching support to the vimgrep command#8152
yegappan wants to merge 1 commit intovim:masterfrom
yegappan:vimgrep

Conversation

@yegappan
Copy link
Member

No description provided.

@vim-ml
Copy link

vim-ml commented Apr 26, 2021 via email

@chrisbra
Copy link
Member

not sure why this is needed now. I approved the GH workflow

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #8152 (cebc3f6) into master (b98cec2) will decrease coverage by 86.87%.
The diff coverage is 0.00%.

❗ Current head cebc3f6 differs from pull request most recent head d8b2987. Consider uploading reports for the commit d8b2987 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #8152       +/-   ##
===========================================
- Coverage   89.34%    2.47%   -86.88%     
===========================================
  Files         148      146        -2     
  Lines      166611   161491     -5120     
===========================================
- Hits       148853     3990   -144863     
- Misses      17758   157501   +139743     
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none ?
huge-gcc-testgui ?
huge-gcc-unittests 2.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ex_cmds.c 0.00% <0.00%> (-92.14%) ⬇️
src/quickfix.c 0.00% <0.00%> (-94.94%) ⬇️
src/search.c 0.00% <0.00%> (-92.44%) ⬇️
src/sha256.c 0.00% <0.00%> (-97.96%) ⬇️
src/digraph.c 0.00% <0.00%> (-97.78%) ⬇️
src/gui_gtk_f.c 0.00% <0.00%> (-97.54%) ⬇️
src/match.c 0.00% <0.00%> (-97.13%) ⬇️
src/crypt_zip.c 0.00% <0.00%> (-97.06%) ⬇️
src/evalbuffer.c 0.00% <0.00%> (-96.83%) ⬇️
src/debugger.c 0.00% <0.00%> (-96.62%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b98cec2...d8b2987. Read the comment docs.

src/quickfix.c Outdated
NULL, // search pattern
0, // nr
0, // type
TRUE // valid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments look misaligned.

@vim-ml
Copy link

vim-ml commented Apr 26, 2021 via email

@Shane-XB-Qian

This comment was marked as off-topic.

@Shane-XB-Qian

This comment was marked as off-topic.

@chrisbra
Copy link
Member

https://github.blog/changelog/2021-04-22-github-actions-maintainers-must-approve-first-time-contributer-workflow-runs/
https://github.blog/2021-04-22-github-actions-update-helping-maintainers-combat-bad-actors/

When I updated the PR, the Github actions now requires maintainer
approval to run again.

Thanks, this is unfortunately a bit annoying. I will check the PR page then more actively and see if I need to approve anything.

@Shane-XB-Qian

This comment was marked as off-topic.

@vim-ml
Copy link

vim-ml commented Apr 27, 2021 via email

seandewar added a commit to seandewar/neovim that referenced this pull request Jan 2, 2022
Problem:    Cannot grep using fuzzy matching.
Solution:   Add the "f" flag to :vimgrep. (Yegappan Lakshmanan, closes vim/vim#8152)
vim/vim@bb01a1e
seandewar added a commit to seandewar/neovim that referenced this pull request Jan 2, 2022
Problem:    Cannot grep using fuzzy matching.
Solution:   Add the "f" flag to :vimgrep. (Yegappan Lakshmanan, closes vim/vim#8152)
vim/vim@bb01a1e
seandewar added a commit to seandewar/neovim that referenced this pull request Jan 2, 2022
Problem:    Cannot grep using fuzzy matching.
Solution:   Add the "f" flag to :vimgrep. (Yegappan Lakshmanan, closes vim/vim#8152)
vim/vim@bb01a1e
seandewar added a commit to seandewar/neovim that referenced this pull request Jan 2, 2022
Problem:    Cannot grep using fuzzy matching.
Solution:   Add the "f" flag to :vimgrep. (Yegappan Lakshmanan, closes vim/vim#8152)
vim/vim@bb01a1e
zeertzjq pushed a commit to seandewar/neovim that referenced this pull request Jan 31, 2022
Problem:    Cannot grep using fuzzy matching.
Solution:   Add the "f" flag to :vimgrep. (Yegappan Lakshmanan, closes vim/vim#8152)
vim/vim@bb01a1e
seandewar added a commit to seandewar/neovim that referenced this pull request Feb 7, 2022
Problem:    Cannot grep using fuzzy matching.
Solution:   Add the "f" flag to :vimgrep. (Yegappan Lakshmanan, closes vim/vim#8152)
vim/vim@bb01a1e
zbirenbaum pushed a commit to zbirenbaum/neovim that referenced this pull request Feb 11, 2022
Problem:    Cannot grep using fuzzy matching.
Solution:   Add the "f" flag to :vimgrep. (Yegappan Lakshmanan, closes vim/vim#8152)
vim/vim@bb01a1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants