Skip to content

Support multibyte character for stl and stlnc items in fillchars#7927

Closed
yegappan wants to merge 1 commit intovim:masterfrom
yegappan:fillchar
Closed

Support multibyte character for stl and stlnc items in fillchars#7927
yegappan wants to merge 1 commit intovim:masterfrom
yegappan:fillchar

Conversation

@yegappan
Copy link
Member

@yegappan yegappan commented Mar 4, 2021

Update the patch by Christian Wellenbrock to support multibyte character for stl and
stlnc items in the 'fillchars' option. Also add additional tests for fold items in fillchars.

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #7927 (38ba32c) into master (2e2d758) will decrease coverage by 0.13%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7927      +/-   ##
==========================================
- Coverage   89.08%   88.94%   -0.14%     
==========================================
  Files         148      148              
  Lines      165155   162175    -2980     
==========================================
- Hits       147124   144253    -2871     
+ Misses      18031    17922     -109     
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none 88.55% <80.00%> (-0.02%) ⬇️
huge-gcc-testgui 87.05% <78.94%> (+<0.01%) ⬆️
huge-gcc-unittests 2.49% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/buffer.c 91.86% <78.94%> (-0.29%) ⬇️
src/screen.c 86.16% <100.00%> (+0.48%) ⬆️
src/help.c 89.76% <0.00%> (-1.08%) ⬇️
src/os_unix.c 70.56% <0.00%> (-0.98%) ⬇️
src/textobject.c 91.69% <0.00%> (-0.71%) ⬇️
src/if_python.c 82.65% <0.00%> (-0.62%) ⬇️
src/ops.c 91.80% <0.00%> (-0.57%) ⬇️
src/ex_cmds2.c 90.68% <0.00%> (-0.54%) ⬇️
src/move.c 93.77% <0.00%> (-0.54%) ⬇️
src/search.c 92.03% <0.00%> (-0.53%) ⬇️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2d758...f1fc2d8. Read the comment docs.

…r for stl and stlnc items in the fillchars option. Add additional tests for fold items in fillchars.
@brammool brammool closed this in 008bff9 Mar 4, 2021
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 18, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Dec 19, 2021
…e byte

Problem:    'fillchars' "stl" and "stlnc" items must be single byte.
Solution:   Accept multi-byte characters. (Christian Wellenbrock, Yegappan
            Lakshmanan, closes vim/vim#7927)
vim/vim@008bff9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant