Codecov Report

Merging #7777 (3777274) into master (92bb83e) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7777      +/-   ##
==========================================
+ Coverage   88.70%   88.92%   +0.22%     
==========================================
  Files         148      144       -4     
  Lines      164696   162819    -1877     
==========================================
- Hits       146088   144786    -1302     
+ Misses      18608    18033     -575     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92bb83e...3777274. Read the comment docs.

Hm, the Windows AppVeyor build fails with:

ex_docmd.c(3685) : error C2275: 'exarg_T' : illegal use of this type as an expression
        c:\projects\vim\src\ex_cmds.h(85) : see declaration of 'exarg_T'

For the line:

exarg_T ea;

Not entirely sure why that should fail, and why it fails only on Windows 🤔

I don't have a Windows machine to test, so if anyone has any hints then that would be appreciated.

exarg_T ea;

can you put this at the beginning of the function please?

MSVC 2010 doesn't support to declare a variable in the middle of the block.

Ah thanks: C89 style. I'm so used to writing it like this I didn't think about that 😅 I updated the PR and it seems grand now.

Well, but couldn't we instead of this just to omit sorting step while expanding "command" specifically, so both getcompletion("syn", "command") will return ["syntax", "syntime", "syncbind"] in this order, and also :syn<tab> will nicely expand into "syntax" first?

Well, but couldn't we instead of this just to omit sorting step while expanding "command" specifically, so both getcompletion("syn", "command") will return ["syntax", "syntime", "syncbind"] in this order, and also :syn<tab> will nicely expand into "syntax" first?

I wouldn't be in favour of that myself; I think the completion and "shortcut" logic are quite different things, and I don't think many people would expect the cmdline completion behaviour to be modified based on that. Having :substitute on top when doing :s<Tab> seems really weird to me, and would be doubly weird with wildmode=full.

Instead of "shorcut" the term "abbreviation" should be used. This is mentioned in section 20.2 of the user manual.
"findcommand" isn't quite right. How about "fullcommand" ?

I avoided using the word "abbreviation" to avoid confusing between this and :abbr abbreviations.

At any rate, I updated the name to fullcommand() and tweaked the help page a bit.