Fix crash when closing window in another tab #7018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and the other tab isn't also closed
Codecov Report
@@ Coverage Diff @@
## master #7018 +/- ##
==========================================
- Coverage 88.61% 88.60% -0.02%
==========================================
Files 148 148
Lines 161693 161693
==========================================
- Hits 143286 143267 -19
- Misses 18407 18426 +19
Continue to review full report at Codecov.
|
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Dec 2, 2022
Problem: Closing split window in other tab may cause a crash. Solution: Set tp_curwin properly. (Rob Pilling, closes vim/vim#7018) vim/vim@f3c51bb Co-authored-by: Bram Moolenaar <Bram@vim.org>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Dec 2, 2022
Problem: Closing split window in other tab may cause a crash. Solution: Set tp_curwin properly. (Rob Pilling, closes vim/vim#7018) vim/vim@f3c51bb Co-authored-by: Bram Moolenaar <Bram@vim.org>
Nero-F
pushed a commit
to Nero-F/neovim
that referenced
this pull request
Dec 16, 2022
Problem: Closing split window in other tab may cause a crash. Solution: Set tp_curwin properly. (Rob Pilling, closes vim/vim#7018) vim/vim@f3c51bb Co-authored-by: Bram Moolenaar <Bram@vim.org>
yesean
pushed a commit
to yesean/neovim
that referenced
this pull request
Mar 25, 2023
Problem: Closing split window in other tab may cause a crash. Solution: Set tp_curwin properly. (Rob Pilling, closes vim/vim#7018) vim/vim@f3c51bb Co-authored-by: Bram Moolenaar <Bram@vim.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and the other tab itself isn't closed. The test contains a short repro, but essentially we end up with a tab's
tp_curwinbecoming dangling.win_free_memalready mitigates this when the tab isn't the current tab, so we fix it for the current tab too.An alternative fix could be to set
tp_curwinat the end ofwin_remove(), but that would affect all other removals too, which usually have their own code to update the current window.