ArgList: Added argdedupe command to remove duplicate arguments#6235
ArgList: Added argdedupe command to remove duplicate arguments#6235nir9 wants to merge 8 commits intovim:masterfrom nir9:master
Conversation
|
This PR adds the ability to ignore duplicate files added with argadd and argedit, if a user attempts to argedit a file that already exists in the args it will not be added to the args and the user will move to the already existing entry. I fixed the tests accordingly. |
|
Problem is that this is not backwards compatible. Some users (and plugins) may depend on the current behavior.
I tend to think that adding :argdedupe might be the best, so you can do ":argedit file | argdedupe" |
|
@brammool Added the argdedupe according to your suggestion, also added a test for the new command |
|
Did you close it just because it was old? There was a note in the todo list, but it has gone down a bit because new things got added. |
|
Oh this is actually by mistake I forgot about this and rebased my forks master branch (I am now working on a different fix) dropping these commits XD so I guess the GitHub automatically closed this pull request I will soon try to restore the commits (looks like they still exist on GitHub) and put them on a different branch and reopen this pull request so they don't get lost. |
|
Hi, I have re-added the original commits, though I have removed the changes I did to the tags and cmdidxs since you can anyway just compile them again easily so no need for them to be included in the changes (they can be compiled once you decide to add this to vim) |
|
Please do include the changes to cmdidxs, so that CI can run and test the change. |
|
@brammool Added the generated cmdidxs :) |
Codecov Report
@@ Coverage Diff @@
## master #6235 +/- ##
==========================================
- Coverage 90.38% 90.38% -0.01%
==========================================
Files 154 154
Lines 173065 173173 +108
==========================================
+ Hits 156421 156518 +97
- Misses 16644 16655 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Problem: The argument list may contain duplicates. Solution: Add the :argdedeupe command. (Nir Lichtman, closes vim/vim#6235) vim/vim@73a0242 Use latest index.txt :argdedeupe doc from Vim.
Problem: The argument list may contain duplicates. Solution: Add the :argdedeupe command. (Nir Lichtman, closes vim/vim#6235) vim/vim@73a0242 Use latest index.txt :argdedupe doc from Vim.
Problem: The argument list may contain duplicates. Solution: Add the :argdedeupe command. (Nir Lichtman, closes vim/vim#6235) vim/vim@73a0242 Use latest index.txt :argdedupe doc from Vim.
…19795) Problem: The argument list may contain duplicates. Solution: Add the :argdedeupe command. (Nir Lichtman, closes vim/vim#6235) vim/vim@73a0242 Use latest index.txt :argdedupe doc from Vim.
Fixing the issue #6210
Added ":argdedupe" command that cleans the args from any duplicates.