Handle non-'/' delimiters for commandline 'incsearch' #5665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, `:s;abc/xyz;replacement;` would only highlight the `abc` part of the search term, since vim would think the '/' was the search delimiter.
k-takata
reviewed
Feb 19, 2020
Member
|
https://travis-ci.org/vim/vim/jobs/652708822#L2980 |
Contributor
Author
|
Interesting, looks like I was bit a overzealous with one of my changes |
glacambre
added a commit
to glacambre/neovim
that referenced
this pull request
Apr 4, 2021
…parator
Problem: Highlighting for :s wrong when using different separator.
Solution: Use separat argument for search direction and separator. (Rob
Pilling, closes vim/vim#5665)
vim/vim@c036e87
glacambre
added a commit
to glacambre/neovim
that referenced
this pull request
Apr 4, 2021
…parator
Problem: Highlighting for :s wrong when using different separator.
Solution: Use separat argument for search direction and separator. (Rob
Pilling, closes vim/vim#5665)
vim/vim@c036e87
glacambre
added a commit
to glacambre/neovim
that referenced
this pull request
Apr 4, 2021
…parator
Problem: Highlighting for :s wrong when using different separator.
Solution: Use separat argument for search direction and separator. (Rob
Pilling, closes vim/vim#5665)
vim/vim@c036e87
glacambre
added a commit
to glacambre/neovim
that referenced
this pull request
Apr 4, 2021
…parator
Problem: Highlighting for :s wrong when using different separator.
Solution: Use separat argument for search direction and separator. (Rob
Pilling, closes vim/vim#5665)
vim/vim@c036e87
glacambre
added a commit
to glacambre/neovim
that referenced
this pull request
Apr 4, 2021
…parator
Problem: Highlighting for :s wrong when using different separator.
Solution: Use separat argument for search direction and separator. (Rob
Pilling, closes vim/vim#5665)
vim/vim@c036e87
glacambre
added a commit
to glacambre/neovim
that referenced
this pull request
Apr 4, 2021
…parator
Problem: Highlighting for :s wrong when using different separator.
Solution: Use separat argument for search direction and separator. (Rob
Pilling, closes vim/vim#5665)
vim/vim@c036e87
janlazo
pushed a commit
to neovim/neovim
that referenced
this pull request
Apr 4, 2021
…parator (#14286) Problem: Highlighting for :s wrong when using different separator. Solution: Use separat argument for search direction and separator. (Rob Pilling, closes vim/vim#5665) vim/vim@c036e87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
:s;abc/xyz;replacement;would only highlight theabcpart of the search term, since Vim would think the/was the search delimiter, not part of the pattern, and stop the highlighting there.We now handle both
dirc- the direction in which to search, and the delimiter, which may or may not be/or?. This is used whendo_search()is deciding on the current search pattern to look for.