win32: Use Wide API in vim_getenv() in misc1.c#4008
Closed
k-takata wants to merge 2 commits intovim:masterfrom
Closed
win32: Use Wide API in vim_getenv() in misc1.c#4008k-takata wants to merge 2 commits intovim:masterfrom
k-takata wants to merge 2 commits intovim:masterfrom
Conversation
Currently, `vim_getenv()` cannot handle Unicode characters on Windows. E.g.: ``` :let $a='Ā' :echo $a ? ``` This patch makes it possible by using Wide API: ``` :let $a='Ā' :echo $a Ā ```
Member
|
Looks good. 👍 Possibly this can be tested? |
Closed
Codecov Report
@@ Coverage Diff @@
## master #4008 +/- ##
==========================================
+ Coverage 79.13% 79.15% +0.01%
==========================================
Files 105 105
Lines 141111 141112 +1
==========================================
+ Hits 111669 111693 +24
+ Misses 29442 29419 -23
Continue to review full report at Codecov.
|
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Nov 7, 2019
…nment var Problem: MS-Windows: cannot use multi-byte chars in environment var. Solution: Use the wide API. (Ken Takata, closes vim/vim#4008) vim/vim@f0908e6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Nov 9, 2019
…nment var Problem: MS-Windows: cannot use multi-byte chars in environment var. Solution: Use the wide API. (Ken Takata, closes vim/vim#4008) vim/vim@f0908e6
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Nov 9, 2019
…nment var Problem: MS-Windows: cannot use multi-byte chars in environment var. Solution: Use the wide API. (Ken Takata, closes vim/vim#4008) vim/vim@f0908e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
vim_getenv()cannot handle Unicode characters on Windows. E.g.:This patch makes it possible by using Wide API: