Skip to content

Support 3rd char of 'tab' of 'listchars'#3810

Closed
k-takata wants to merge 2 commits intovim:masterfrom
k-takata:tab-xyz
Closed

Support 3rd char of 'tab' of 'listchars'#3810
k-takata wants to merge 2 commits intovim:masterfrom
k-takata:tab-xyz

Conversation

@k-takata
Copy link
Member

This patch was originally written by Nathaniel Braun:
https://groups.google.com/d/msg/vim_dev/bq9vyCYm7CU/ZuIA-_H9xaMJ

I updated it for the latest code and added the tests.

Now set listchars=tab:--> shows a tab as an arrow. E.g. >, ->, -->, --->, ...
and set listchars=tab:<=> shows >, <>, <=>, <==>, ...

@codecov-io
Copy link

Codecov Report

Merging #3810 into master will increase coverage by <.01%.
The diff coverage is 79.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3810      +/-   ##
==========================================
+ Coverage   78.47%   78.48%   +<.01%     
==========================================
  Files         103      103              
  Lines      141893   141931      +38     
==========================================
+ Hits       111356   111388      +32     
- Misses      30537    30543       +6
Impacted Files Coverage Δ
src/screen.c 79.18% <77.77%> (-0.03%) ⬇️
src/message.c 75.88% <77.77%> (+0.08%) ⬆️
src/option.c 85.74% <87.5%> (-0.01%) ⬇️
src/if_xcmdsrv.c 84.17% <0%> (-0.18%) ⬇️
src/channel.c 83.32% <0%> (-0.08%) ⬇️
src/window.c 83.39% <0%> (-0.07%) ⬇️
src/ex_cmds.c 80.08% <0%> (+0.09%) ⬆️
src/gui.c 57.95% <0%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d896824...02e1ab8. Read the comment docs.

@brammool brammool closed this in 83a5217 Jan 16, 2019
@k-takata k-takata deleted the tab-xyz branch January 16, 2019 22:50
mhinz added a commit to mhinz/neovim that referenced this pull request Jan 25, 2019
Problem:    Showing two characters for tab is limited.
Solution:   Allow for a third character for "tab:" in 'listchars'. (Nathaniel
            Braun, Ken Takata, closes vim/vim#3810)

vim/vim@83a5217
mhinz added a commit to mhinz/neovim that referenced this pull request Jan 25, 2019
Problem:    Showing two characters for tab is limited.
Solution:   Allow for a third character for "tab:" in 'listchars'. (Nathaniel
            Braun, Ken Takata, closes vim/vim#3810)

vim/vim@83a5217
mhinz added a commit to mhinz/neovim that referenced this pull request Jan 26, 2019
Problem:    Showing two characters for tab is limited.
Solution:   Allow for a third character for "tab:" in 'listchars'. (Nathaniel
            Braun, Ken Takata, closes vim/vim#3810)

vim/vim@83a5217
mhinz added a commit to mhinz/neovim that referenced this pull request Jan 26, 2019
Problem:    Showing two characters for tab is limited.
Solution:   Allow for a third character for "tab:" in 'listchars'. (Nathaniel
            Braun, Ken Takata, closes vim/vim#3810)

vim/vim@83a5217
QazerLab added a commit to QazerLab/workbench that referenced this pull request Jul 18, 2019
The documentation for listchars clearly says that the tab symbol
requires two-char highlighing sequence. Previously, single-char sequence
worked, but this was fixed by vim/vim#3810 and
introduced a regression to vimrc from this playbook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants