Fix OS X build on CI #2203
Closed
Fix OS X build on CI #2203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brew-update installs its own ruby binary and brew uses it after that. But, when brew-update does in brew-install, brew-install keeps to use previous ruby (system-default ruby, 2.0.0) and it is not able to run latest brew, requires ruby 2.3 or later. Thus should do separately brew-update and brew-install and preferable to set 'HOMEBREW_NO_AUTO_UPDATE' to avoid unnecessary brew-updating.
Codecov Report
@@ Coverage Diff @@
## master #2203 +/- ##
==========================================
+ Coverage 74.25% 74.27% +0.01%
==========================================
Files 90 90
Lines 131984 131983 -1
Branches 28987 30858 +1871
==========================================
+ Hits 98007 98024 +17
+ Misses 33952 33930 -22
- Partials 25 29 +4
Continue to review full report at Codecov.
|
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
Problem: Building with lua fails for OSX on Travis. Solution: Separate brew-update and brew-install. (Ozaki Kiichi, closes vim#2203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest brew requires ruby 2.3 or later, and
brew-updateinstalls its own ruby binary.brew-installdoesbrew-updateunder its process, butbrew-installis continued on the previous ruby envs (system default:2.0.0), so brew reports ruby-version error.To fix it:
brew-updateandbrew-installbrew-installwithHOMEBREW_NO_AUTO_UPDATE=1(means don't dobrew-updateinbrew-install)