Fix memory leak and don't initialize to w_hl to NULL in win_init_empty()#19609
Closed
64-bitman wants to merge 1 commit intovim:masterfrom
Closed
Fix memory leak and don't initialize to w_hl to NULL in win_init_empty()#1960964-bitman wants to merge 1 commit intovim:masterfrom
64-bitman wants to merge 1 commit intovim:masterfrom
Conversation
Member
|
should be fixed already by #19607 |
Contributor
Author
Member
|
okay, can you update this PR? |
21b42f1 to
0320bd4
Compare
Contributor
Author
Done |
Member
|
Thansk. I was actually wondering if |
Contributor
Author
|
@chrisbra Can you not merge this PR yet? I think I found the real source of the crash I've been experiencing |
732d0f3 to
2d4b34c
Compare
2d4b34c to
7dba856
Compare
Contributor
Author
|
Okay I think this can be merged now. |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By setting
w_hlto NULL inwin_init_empty(), switching to a new file (e.g.:e file) will clear all window local highlights for the window.Fix memory leak found in ASAN CI test