memory leak in w_hl when reusing a popup window#19607
Closed
chrisbra wants to merge 1 commit intovim:masterfrom
Closed
memory leak in w_hl when reusing a popup window#19607chrisbra wants to merge 1 commit intovim:masterfrom
chrisbra wants to merge 1 commit intovim:masterfrom
Conversation
Problem: When a popup info window is reused, win_init_empty() resets
w_hl to NULL without freeing the previously allocated value,
causing a memory leak (after v9.2.0113)
Solution: Free w_hl before resetting it to NULL in win_init_empty().
Signed-off-by: Christian Brabandt <cb@256bit.org>
yegappan
reviewed
Mar 7, 2026
| wp->w_prev_pcmark.col = 0; | ||
| wp->w_topline = 1; | ||
| // in case it was already set | ||
| vim_free(wp->w_hl); |
Member
There was a problem hiding this comment.
VIM_CLEAR(wp->w_hl) can be used here.
Member
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When a popup info window is reused, win_init_empty() resets
w_hl to NULL without freeing the previously allocated value,
causing a memory leak (after v9.2.0113)
Solution: Free w_hl before resetting it to NULL in win_init_empty().