Fix memory leak in expand_findfunc() in src/ex_docmd.c#19564
Closed
huanghuihui0904 wants to merge 1 commit intovim:masterfrom
Closed
Fix memory leak in expand_findfunc() in src/ex_docmd.c#19564huanghuihui0904 wants to merge 1 commit intovim:masterfrom
expand_findfunc() in src/ex_docmd.c#19564huanghuihui0904 wants to merge 1 commit intovim:masterfrom
Conversation
Signed-off-by: huanghuihui0904 <625173@qq.com>
Member
|
thanks |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Mar 4, 2026
Problem: memory leak in expand_findfunc() (after v9.1.0811) Solution: Free list variable l on early return (Huihui Huang). closes: vim/vim#19564 vim/vim@648240f N/A patches: vim-patch:9.2.0105: memory leak in heredoc_get() in src/evalvars.c Co-authored-by: Huihui Huang <625173@qq.com>
ZieMcd
pushed a commit
to ZieMcd/neovim
that referenced
this pull request
Mar 6, 2026
Problem: memory leak in expand_findfunc() (after v9.1.0811) Solution: Free list variable l on early return (Huihui Huang). closes: vim/vim#19564 vim/vim@648240f N/A patches: vim-patch:9.2.0105: memory leak in heredoc_get() in src/evalvars.c Co-authored-by: Huihui Huang <625173@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
expand_findfunc(), the listlis allocated bycall_findfunc()(lines 7076–7079):However, there are early-return paths after
lis allocated (lines 7081–7087):On these failure paths,
lis not freed. Sincelist_free(l)is only called on the success path near the end of the function,lis leaked when returning early.Solution
Free
lbefore returning on error paths. The fix is included in this commit.