Skip to content

:wqall! doesn't close a terminal buffer like :qall! does#19129

Closed
zeertzjq wants to merge 1 commit intovim:masterfrom
zeertzjq:terminal-wqall-bang
Closed

:wqall! doesn't close a terminal buffer like :qall! does#19129
zeertzjq wants to merge 1 commit intovim:masterfrom
zeertzjq:terminal-wqall-bang

Conversation

@zeertzjq
Copy link
Member

@zeertzjq zeertzjq commented Jan 8, 2026

Problem: :wqall! doesn't close a terminal buffer like :qall! does
(after 8.0.1525).
Solution: Check eap->forceit.

Ref #2654 (comment)

realted: #2654
related: neovim/neovim#14061

@zeertzjq zeertzjq force-pushed the terminal-wqall-bang branch from 4c17f0d to cc8ceb8 Compare January 8, 2026 03:13
Problem:  :wqall! doesn't close a terminal buffer like :qall! does
          (after 8.0.1525).
Solution: Check eap->forceit.

Ref vim#2654 (comment)

related: vim#2654
related: neovim/neovim#14061
@zeertzjq zeertzjq force-pushed the terminal-wqall-bang branch from cc8ceb8 to 3ca97c6 Compare January 8, 2026 03:18
@chrisbra
Copy link
Member

chrisbra commented Jan 8, 2026

Unrelated to the actual change, but what is wrong with those sudden failures?

clang -c -I. -DPERL_DARWIN -DNO_THREAD_SAFE_QUERYLOCALE -DNO_POSIX_2008_LOCALE -DHAS_BROKEN_LANGINFO_CODESET -DNO_LOCALE_COLLATE -fno-strict-aliasing -fstack-protector-strong  -I/opt/homebrew/opt/perl/lib/perl5/5.42/darwin-thread-multi-2level/CORE  -Iproto -DHAVE_CONFIG_H   -DMACOS_X -DMACOS_X_DARWIN -I/opt/homebrew/Cellar/libsodium/1.0.20/include  -g -O2  -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -Wall -Wextra -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Werror -Wno-deprecated-declarations -Wno-error=missing-field-initializers   -DEXITFREE     -Wno-error=unused-function -Wno-shadow -Wno-error=compound-token-split-by-macro -Wno-compound-token-split-by-macro -o objects/if_perl.o auto/if_perl.c
clang -c -I. -I/opt/homebrew/opt/python@3.14/Frameworks/Python.framework/Versions/3.14/include/python3.14 -fPIE -Iproto -DHAVE_CONFIG_H   -DMACOS_X -DMACOS_X_DARWIN -I/opt/homebrew/Cellar/libsodium/1.0.20/include  -g -O2  -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -Wall -Wextra -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Werror -Wno-deprecated-declarations -Wno-error=missing-field-initializers   -DEXITFREE      -o objects/if_python3.o if_python3.c
In file included from if_perl.xs:49:
/opt/homebrew/opt/perl/lib/perl5/5.42/darwin-thread-multi-2level/CORE/perl.h:5338:32: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
 5338 | typedef void (*shutdown_proc_t)();
      |                                ^
      |                                 void
1 error generated.
make[1]: *** [objects/if_perl.o] Error 1

That seems to happen inside the Perl header. Can we fix the CI?

@zeertzjq
Copy link
Member Author

zeertzjq commented Jan 8, 2026

#19132 seems to fix that

@chrisbra
Copy link
Member

chrisbra commented Jan 8, 2026

thanks

@chrisbra chrisbra closed this in d8558fd Jan 8, 2026
@zeertzjq zeertzjq deleted the terminal-wqall-bang branch January 8, 2026 22:49
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Jan 8, 2026
Problem:  :wqall! doesn't close a terminal buffer like :qall! does
          (after 8.0.1525).
Solution: Check eap->forceit (zeertzjq).

Ref: vim/vim#2654 (comment)

related: vim/vim#2654
related: neovim#14061
closes:  vim/vim#19129

vim/vim@d8558fd
zeertzjq added a commit to neovim/neovim that referenced this pull request Jan 8, 2026
…#37314)

Problem:  :wqall! doesn't close a terminal buffer like :qall! does
          (after 8.0.1525).
Solution: Check eap->forceit (zeertzjq).

Ref: vim/vim#2654 (comment)

related: vim/vim#2654
related: #14061
closes:  vim/vim#19129

vim/vim@d8558fd
github-actions bot pushed a commit to neovim/neovim that referenced this pull request Jan 8, 2026
…#37314)

Problem:  :wqall! doesn't close a terminal buffer like :qall! does
          (after 8.0.1525).
Solution: Check eap->forceit (zeertzjq).

Ref: vim/vim#2654 (comment)

related: vim/vim#2654
related: #14061
closes:  vim/vim#19129

vim/vim@d8558fd
(cherry picked from commit 681d006)
github-actions bot pushed a commit to neovim/neovim that referenced this pull request Jan 9, 2026
…#37314)

Problem:  :wqall! doesn't close a terminal buffer like :qall! does
          (after 8.0.1525).
Solution: Check eap->forceit (zeertzjq).

Ref: vim/vim#2654 (comment)

related: vim/vim#2654
related: #14061
closes:  vim/vim#19129

vim/vim@d8558fd
(cherry picked from commit 681d006)
HarshK97 pushed a commit to HarshK97/neovim that referenced this pull request Feb 13, 2026
…neovim#37314)

Problem:  :wqall! doesn't close a terminal buffer like :qall! does
          (after 8.0.1525).
Solution: Check eap->forceit (zeertzjq).

Ref: vim/vim#2654 (comment)

related: vim/vim#2654
related: neovim#14061
closes:  vim/vim#19129

vim/vim@d8558fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants