Sorting a list of large numbers (> 32 bits) using a function with sort() doesn't work#18868
Closed
yegappan wants to merge 1 commit intovim:masterfrom
Closed
Sorting a list of large numbers (> 32 bits) using a function with sort() doesn't work#18868yegappan wants to merge 1 commit intovim:masterfrom
yegappan wants to merge 1 commit intovim:masterfrom
Conversation
Member
|
thanks |
|
Found the bug. Thanks for the fix! |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Dec 6, 2025
…ectly
Problem: sort() does not handle large numbers correctly
(Igbanam Ogbuluijah)
Solution: Don't truncate the return value of tv_get_number_chk()
(Yegappan Lakshmanan)
closes: vim/vim#18868
vim/vim@04794ef
Use a Lua test for now, as the Vimscript test uses tuples.
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Dec 6, 2025
…ectly (#36840) Problem: sort() does not handle large numbers correctly (Igbanam Ogbuluijah) Solution: Don't truncate the return value of tv_get_number_chk() (Yegappan Lakshmanan) closes: vim/vim#18868 vim/vim@04794ef Use a Lua test for now, as the Vimscript test uses tuples. Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
github-actions bot
pushed a commit
to neovim/neovim
that referenced
this pull request
Dec 6, 2025
…ectly (#36840) Problem: sort() does not handle large numbers correctly (Igbanam Ogbuluijah) Solution: Don't truncate the return value of tv_get_number_chk() (Yegappan Lakshmanan) closes: vim/vim#18868 vim/vim@04794ef Use a Lua test for now, as the Vimscript test uses tuples. Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com> (cherry picked from commit 5370b7a)
github-actions bot
pushed a commit
to neovim/neovim
that referenced
this pull request
Dec 6, 2025
…ectly (#36840) Problem: sort() does not handle large numbers correctly (Igbanam Ogbuluijah) Solution: Don't truncate the return value of tv_get_number_chk() (Yegappan Lakshmanan) closes: vim/vim#18868 vim/vim@04794ef Use a Lua test for now, as the Vimscript test uses tuples. Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com> (cherry picked from commit 5370b7a)
yochem
pushed a commit
to yochem/neovim
that referenced
this pull request
Dec 15, 2025
…ectly (neovim#36840) Problem: sort() does not handle large numbers correctly (Igbanam Ogbuluijah) Solution: Don't truncate the return value of tv_get_number_chk() (Yegappan Lakshmanan) closes: vim/vim#18868 vim/vim@04794ef Use a Lua test for now, as the Vimscript test uses tuples. Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't truncate the return value of tv_get_number_chk().