Fix: remove hl-ComplMatchIns usage during "preinsert"#18254
Closed
girishji wants to merge 2 commits intovim:masterfrom
Closed
Fix: remove hl-ComplMatchIns usage during "preinsert"#18254girishji wants to merge 2 commits intovim:masterfrom
girishji wants to merge 2 commits intovim:masterfrom
Conversation
When `"preinsert"` is included in `'completeopt'`, only the `hl-PreInsert` highlight group should be applied, whether autocompletion is active or not. Previously, `hl-ComplMatchIns` was used when autocompletion was not enabled. Related to vim#18213.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
thanks |
Contributor
Author
|
Thanks. |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Sep 10, 2025
…plMatchIns
Problem: completion: preinserted text highlighed using ComplMatchIns
Solution: Use highlighting group PreInsert and update the documentation
(Girish Palya).
When "preinsert" is included in 'completeopt', only the PreInsert
highlight group should be applied, whether autocompletion is active or not.
Previously, ComplMatchIns was used when autocompletion was not enabled.
Related to vim/vim#18213.
closes: vim/vim#18254
vim/vim@2525c56
Co-authored-by: Girish Palya <girishji@gmail.com>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Sep 10, 2025
…plMatchIns
Problem: completion: preinserted text highlighed using ComplMatchIns
Solution: Use highlighting group PreInsert and update the documentation
(Girish Palya).
When "preinsert" is included in 'completeopt', only the PreInsert
highlight group should be applied, whether autocompletion is active or not.
Previously, ComplMatchIns was used when autocompletion was not enabled.
Related to vim/vim#18213.
closes: vim/vim#18254
vim/vim@2525c56
Co-authored-by: Girish Palya <girishji@gmail.com>
dundargoc
pushed a commit
to dundargoc/neovim
that referenced
this pull request
Sep 27, 2025
…plMatchIns
Problem: completion: preinserted text highlighed using ComplMatchIns
Solution: Use highlighting group PreInsert and update the documentation
(Girish Palya).
When "preinsert" is included in 'completeopt', only the PreInsert
highlight group should be applied, whether autocompletion is active or not.
Previously, ComplMatchIns was used when autocompletion was not enabled.
Related to vim/vim#18213.
closes: vim/vim#18254
vim/vim@2525c56
Co-authored-by: Girish Palya <girishji@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
"preinsert"is included in'completeopt', only thehl-PreInserthighlight group should be applied. Previously,hl-ComplMatchInswas used when autocompletion was not enabled.Related to #18213.