Remove unneeded logic #16778
Closed
Remove unneeded logic #16778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`options` needs to be passed into nextwild() since it may contain WILD_KEEP_SOLE_ITEM which prevents the menu items list from getting freed if there is only 1 item left (if `noselect` is set). M src/ex_getln.c
Member
|
thanks |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Mar 3, 2025
Problem: wrong flags passed down to nextwild()
(zeertzjq, after v9.1.1166)
Solution: only pass options flags (Girish Palya)
`options` needs to be passed into nextwild() since it may contain
WILD_KEEP_SOLE_ITEM which prevents the menu items list from getting
freed if there is only 1 item left (if `noselect` is set).
closes: vim/vim#16778
vim/vim@d2219d5
Co-authored-by: Girish Palya <girishji@gmail.com>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Mar 3, 2025
Problem: wrong flags passed down to nextwild()
(zeertzjq, after v9.1.1166)
Solution: only pass options flags (Girish Palya)
`options` needs to be passed into nextwild() since it may contain
WILD_KEEP_SOLE_ITEM which prevents the menu items list from getting
freed if there is only 1 item left (if `noselect` is set).
closes: vim/vim#16778
vim/vim@d2219d5
Co-authored-by: Girish Palya <girishji@gmail.com>
zeertzjq
added a commit
to deathbeam/neovim
that referenced
this pull request
Mar 3, 2025
Problem: wrong flags passed down to nextwild()
(zeertzjq, after v9.1.1166)
Solution: only pass options flags (Girish Palya)
`options` needs to be passed into nextwild() since it may contain
WILD_KEEP_SOLE_ITEM which prevents the menu items list from getting
freed if there is only 1 item left (if `noselect` is set).
closes: vim/vim#16778
vim/vim@d2219d5
Co-authored-by: Girish Palya <girishji@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optionsneeds to be passed into nextwild() since it may contain WILD_KEEP_SOLE_ITEM which prevents the menu items list from getting freed if there is only 1 item left (ifnoselectis set).#16759 (comment)
M src/ex_getln.c