Refactor the f_indexof() function, update the help and add additional test#10908
Closed
yegappan wants to merge 1 commit intovim:masterfrom
Closed
Refactor the f_indexof() function, update the help and add additional test#10908yegappan wants to merge 1 commit intovim:masterfrom
yegappan wants to merge 1 commit intovim:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10908 +/- ##
=======================================
Coverage 82.68% 82.69%
=======================================
Files 148 148
Lines 173693 173698 +5
Branches 39246 39246
=======================================
+ Hits 143626 143634 +8
+ Misses 17480 17478 -2
+ Partials 12587 12586 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lacygoill
reviewed
Aug 13, 2022
runtime/doc/builtin.txt
Outdated
| start start evaluating {expr} at the item with index | ||
| {start} (may be negative for an item relative | ||
| startidx start evaluating {expr} at the item with index | ||
| staridx (may be negative for an item relative |
There was a problem hiding this comment.
I think staridx should be replaced with {startidx}.
Contributor
There was a problem hiding this comment.
I'll include the correction.
jamespeapen
pushed a commit
to jamespeapen/vim
that referenced
this pull request
Sep 21, 2022
Problem: Code and help for indexof() is not ideal.
Solution: Refactor the code, improve the help. (Yegappan Lakshmanan,
closes vim#10908)
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Feb 26, 2023
Problem: Code and help for indexof() is not ideal.
Solution: Refactor the code, improve the help. (Yegappan Lakshmanan,
closes vim/vim#10908)
vim/vim@3fbf6cd
Skip: CHECK_LIST_MATERIALIZE and set_vim_var_type().
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Feb 26, 2023
Problem: Code and help for indexof() is not ideal.
Solution: Refactor the code, improve the help. (Yegappan Lakshmanan,
closes vim/vim#10908)
vim/vim@3fbf6cd
Skip CHECK_LIST_MATERIALIZE and set_vim_var_type().
Use tv_list_uidx() instead of lv_idx.
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
yesean
pushed a commit
to yesean/neovim
that referenced
this pull request
Mar 25, 2023
Problem: Code and help for indexof() is not ideal.
Solution: Refactor the code, improve the help. (Yegappan Lakshmanan,
closes vim/vim#10908)
vim/vim@3fbf6cd
Skip CHECK_LIST_MATERIALIZE and set_vim_var_type().
Use tv_list_uidx() instead of lv_idx.
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.