[RFC] Add getcmdscreenpos() and getcmdcompltype()#10344
Closed
Shougo wants to merge 10 commits intovim:masterfrom
Closed
[RFC] Add getcmdscreenpos() and getcmdcompltype()#10344Shougo wants to merge 10 commits intovim:masterfrom
Shougo wants to merge 10 commits intovim:masterfrom
Conversation
Contributor
I'll give you a small hint, check Vim's declaration of |
Contributor
Author
|
Thank you. I have fixed it. But it does not fix my errors.
|
Contributor
Author
|
I have fixed the errors. |
Contributor
|
Is this still WIP? |
|
From the name of the diff --git a/runtime/doc/builtin.txt b/runtime/doc/builtin.txt
index 6abf76706..2ad34ffcf 100644
--- a/runtime/doc/builtin.txt
+++ b/runtime/doc/builtin.txt
@@ -213,8 +213,8 @@ getcharmod() Number modifiers for the last typed character
getcharpos({expr}) List position of cursor, mark, etc.
getcharsearch() Dict last character search
getcharstr([expr]) String get one character from the user
-getcmdcompletion() String return the current command-line
- completion
+getcmdcompletion() String return the type of the current
+ command-line completion
getcmdline() String return the current command-line
getcmdpos() Number return cursor position in command-line
getcmdscreenpos() Number return cursor screen position in
@@ -3213,9 +3213,9 @@ getcharstr([expr]) *getcharstr()*
result is converted to a string.
getcmdcompletion() *getcmdcompletion()*
- Return the current command-line completion type. Only works
- when the command line is being edited, thus requires use of
- |c_CTRL-\_e| or |c_CTRL-R_=|.
+ Return the type of the current command-line completion.
+ Only works when the command line is being edited, thus requires
+ use of |c_CTRL-\_e| or |c_CTRL-R_=|.
See |command-completion| for the return string.
Also see |getcmdtype()|, |setcmdpos()| and |getcmdline()|.
Returns an empty string when completion is not defined.
diff --git a/runtime/doc/usr_41.txt b/runtime/doc/usr_41.txt
index c9b79e797..abcbd3453 100644
--- a/runtime/doc/usr_41.txt
+++ b/runtime/doc/usr_41.txt
@@ -976,7 +976,8 @@ Buffers, windows and the argument list:
swapname() get the swap file path of a buffer
Command line: *command-line-functions*
- getcmdcompletion() get the current command line completion
+ getcmdcompletion() get the type of the current command line
+ completion
getcmdline() get the current command line
getcmdpos() get position of the cursor in the command line
getcmdscreenpos() get screen position of the cursor in theFWIW, if it's not too late, I would also consider including "type" in the name of the function itself: I did a quick test, and both |
Contributor
Author
Sorry. It is not WIP. |
Contributor
Author
|
I have renamed the function name. |
Contributor
|
When I see getcmdcmptype() I guess "cmp" stands for compare, but it means completion. |
Contributor
Author
|
OK. I have renamed. |
Member
|
|
zeertzjq
pushed a commit
to Shougo/neovim
that referenced
this pull request
May 9, 2022
vim-patch:8.2.4903: cannot get the current cmdline completion type and position
Problem: Cannot get the current cmdline completion type and position.
Solution: Add getcmdcompltype() and getcmdscreenpos(). (Shougo Matsushita,
closes vim/vim#10344)
vim/vim@79d599b
vim-patch:8.2.4910: imperfect coding
Problem: Imperfect coding.
Solution: Make code nicer.
vim/vim@9ff7d71
zeertzjq
pushed a commit
to Shougo/neovim
that referenced
this pull request
May 9, 2022
vim-patch:8.2.4903: cannot get the current cmdline completion type and position
Problem: Cannot get the current cmdline completion type and position.
Solution: Add getcmdcompltype() and getcmdscreenpos(). (Shougo Matsushita,
closes vim/vim#10344)
vim/vim@79d599b
vim-patch:8.2.4910: imperfect coding
Problem: Imperfect coding.
Solution: Make code nicer.
vim/vim@9ff7d71
zeertzjq
pushed a commit
to neovim/neovim
that referenced
this pull request
May 9, 2022
vim-patch:8.2.4903: cannot get the current cmdline completion type and position
Problem: Cannot get the current cmdline completion type and position.
Solution: Add getcmdcompltype() and getcmdscreenpos(). (Shougo Matsushita,
closes vim/vim#10344)
vim/vim@79d599b
vim-patch:8.2.4910: imperfect coding
Problem: Imperfect coding.
Solution: Make code nicer.
vim/vim@9ff7d71
kraftwerk28
pushed a commit
to kraftwerk28/neovim
that referenced
this pull request
Jun 1, 2022
vim-patch:8.2.4903: cannot get the current cmdline completion type and position
Problem: Cannot get the current cmdline completion type and position.
Solution: Add getcmdcompltype() and getcmdscreenpos(). (Shougo Matsushita,
closes vim/vim#10344)
vim/vim@79d599b
vim-patch:8.2.4910: imperfect coding
Problem: Imperfect coding.
Solution: Make code nicer.
vim/vim@9ff7d71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. This is the port of neovim/neovim#18284.
It is useful for popup competion in command line mode.
getcmdscreenpos()works for me. Butgetcmdcompletion()does not work well on Vim.It works on neovim.I think the implementation is same with Vim and neovim.But the completion context seems wrong....Can you check my implementation?