Skip to content

Implement isabsolutepath()#10303

Closed
LemonBoy wants to merge 1 commit intovim:masterfrom
LemonBoy:iap
Closed

Implement isabsolutepath()#10303
LemonBoy wants to merge 1 commit intovim:masterfrom
LemonBoy:iap

Conversation

@LemonBoy
Copy link
Contributor

This is statistically one of the most reimplemented function by plugin
writers with different degrees of accuracy: some of them use regexps
while others only check the presence of the root path separator).

This is statistically one of the most reimplemented function by plugin
writers with different degrees of accuracy: some of them use regexps
while others only check the presence of the root path separator).
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #10303 (c5975af) into master (0665163) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #10303      +/-   ##
==========================================
+ Coverage   80.98%   80.99%   +0.01%     
==========================================
  Files         161      161              
  Lines      185621   185625       +4     
  Branches    41969    41970       +1     
==========================================
+ Hits       150319   150343      +24     
+ Misses      22783    22760      -23     
- Partials    12519    12522       +3     
Flag Coverage Δ
huge-clang-none 82.46% <50.00%> (+0.01%) ⬆️
linux 82.46% <50.00%> (+0.01%) ⬆️
mingw-x64-HUGE 0.00% <0.00%> (ø)
mingw-x64-HUGE-gui 77.24% <100.00%> (+<0.01%) ⬆️
windows 76.03% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/evalfunc.c 90.62% <ø> (ø)
src/filepath.c 82.41% <50.00%> (-0.08%) ⬇️
src/terminal.c 77.33% <0.00%> (-0.06%) ⬇️
src/os_win32.c 57.11% <0.00%> (-0.04%) ⬇️
src/channel.c 83.90% <0.00%> (ø)
src/getchar.c 84.01% <0.00%> (ø)
src/buffer.c 86.47% <0.00%> (+0.03%) ⬆️
src/popupwin.c 87.32% <0.00%> (+0.04%) ⬆️
src/term.c 72.67% <0.00%> (+0.05%) ⬆️
src/netbeans.c 72.81% <0.00%> (+0.07%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0665163...c5975af. Read the comment docs.

@brammool brammool closed this in dca1d40 Apr 28, 2022
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 6, 2024
Problem:    Checking for absolute path is not trivial.
Solution:   Add isabsolutepath(). (closes vim/vim#10303)

vim/vim@dca1d40

Co-authored-by: LemonBoy <thatlemon@gmail.com>
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 6, 2024
Problem:    Checking for absolute path is not trivial.
Solution:   Add isabsolutepath(). (closes vim/vim#10303)

vim/vim@dca1d40

Co-authored-by: LemonBoy <thatlemon@gmail.com>
zeertzjq added a commit to neovim/neovim that referenced this pull request Aug 6, 2024
Problem:    Checking for absolute path is not trivial.
Solution:   Add isabsolutepath(). (closes vim/vim#10303)

vim/vim@dca1d40

vim-patch:8a3b805c6c9c

Co-authored-by: LemonBoy <thatlemon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant