Add support for evaluating Vim expressions in a heredoc by yegappan · Pull Request #10138 · vim/vim

yegappan · 2022-04-10T00:22:02Z

No description provided.

codecov · 2022-04-10T00:29:51Z

Codecov Report

Merging #10138 (50fd646) into master (34ffa10) will increase coverage by 2.72%.
The diff coverage is 98.75%.

❗ Current head 50fd646 differs from pull request most recent head 3d84a66. Consider uploading reports for the commit 3d84a66 to get more accurate results

@@            Coverage Diff             @@
##           master   #10138      +/-   ##
==========================================
+ Coverage   80.95%   83.67%   +2.72%     
==========================================
  Files         161      154       -7     
  Lines      185383   176636    -8747     
  Branches    41905    39726    -2179     
==========================================
- Hits       150076   147806    -2270     
+ Misses      22765    16789    -5976     
+ Partials    12542    12041     -501

Flag	Coverage Δ
huge-clang-none	`82.40% <96.25%> (-0.01%)`	⬇️
huge-gcc-none	`82.74% <98.71%> (?)`
huge-gcc-unittests	`2.00% <0.00%> (?)`
linux	`83.67% <98.75%> (+1.26%)`	⬆️
mingw-x64-HUGE	`?`
mingw-x64-HUGE-gui	`?`
windows	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/evalvars.c	`91.01% <98.57%> (-0.25%)`	⬇️
src/userfunc.c	`89.22% <100.00%> (-0.38%)`	⬇️
src/libvterm/src/unicode.c	`70.83% <0.00%> (-13.17%)`	⬇️
src/if_perl.xs	`77.32% <0.00%> (-4.24%)`	⬇️
src/highlight.c	`78.66% <0.00%> (-2.59%)`	⬇️
src/misc2.c	`87.21% <0.00%> (-1.78%)`	⬇️
src/time.c	`87.61% <0.00%> (-1.71%)`	⬇️
src/arabic.c	`93.47% <0.00%> (-1.65%)`	⬇️
src/sha256.c	`94.89% <0.00%> (-1.55%)`	⬇️
src/buffer.c	`84.86% <0.00%> (-1.47%)`	⬇️
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ffa10...3d84a66. Read the comment docs.

brammool · 2022-04-10T18:24:51Z

Let's leave this open a few days to allow for comments.

I'm not sure if we should use =expr or just expr. Compared to other places in Vim =expr would be more common,
but compared to any other language expr would be preferred.

The help is not clear: can the expression span multiple lines? So I could use

some literal text `=
 expr line
  expr line
` more literal text

vim-ml · 2022-04-10T18:56:15Z

Hi Bram,

On Sun, Apr 10, 2022 at 11:25 AM Bram Moolenaar ***@***.***> wrote: Let's leave this open a few days to allow for comments. I'm not sure if we should use =expr or just expr. Compared to other places in Vim =expr would be more common, but compared to any other language expr would be preferred. The help is not clear: can the expression span multiple lines? So I could use

An expression must be within a single line and cannot span multiple lines. I will update the help to reflect this. Regards, Yegappan

…

some literal text `= expr line expr line ` more literal text

lacygoill · 2022-04-11T03:53:21Z

I'm not sure if we should use =expr or just expr. Compared to other places in Vim =expr would be more common,
but compared to any other language expr would be preferred.

Yes, I suggested backtick equal to be as consistent as possible with the existing syntax, but in practice I suspect it's hardly ever used. Dropping the equal sign might make it easier for people coming from other languages to assimilate this new syntax.

vim-ml · 2022-04-11T04:52:56Z

Hi Bram,

On Sun, Apr 10, 2022 at 8:53 PM lacygoill ***@***.***> wrote: I'm not sure if we should use =expr or just expr. Compared to other places in Vim =expr would be more common, but compared to any other language expr would be preferred. Yes, I suggested backtick equal to be as consistent as possible with the existing syntax, but in practice I suspect it's hardly ever used. Dropping the equal sign might make it easier for people coming from other languages to assimilate this new syntax.

Should we support using only backtick for expanding the Vim expression in a heredoc? Thanks, Yegappan

vim-ml · 2022-04-11T10:00:18Z

On Sun, Apr 10, 2022 at 11:25 AM Bram Moolenaar ***@***.***> wrote: > Let's leave this open a few days to allow for comments. > > I'm not sure if we should use =expr or just expr. Compared to other > places in Vim =expr would be more common, > but compared to any other language expr would be preferred. > > The help is not clear: can the expression span multiple lines? So I could > use An expression must be within a single line and cannot span multiple lines. I will update the help to reflect this.

I suppose that will cover most use cases. I expect most use will just be a variable or something like "shellescape(bufname(bnr))".

…

-- ARTHUR: Be quiet! I order you to shut up. OLD WOMAN: Order, eh -- who does he think he is? ARTHUR: I am your king! OLD WOMAN: Well, I didn't vote for you. "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

brammool · 2022-04-13T10:29:45Z

The help says "If the expression evaluation fails, then it is replaced with an empty string."
I think it's better to treat an error like an error and not silently use an empty string.
If you would have an assignment with a faling expression, it would also fail.

yegappan · 2022-04-13T15:28:32Z

The help says "If the expression evaluation fails, then it is replaced with an empty string."
I think it's better to treat an error like an error and not silently use an empty string.
If you would have an assignment with a faling expression, it would also fail.

I have updated the PR to fail the assignment if an expression evaluation fails.

brammool · 2022-04-17T10:51:14Z

I have not seen comments objecting to using the "=expr" form, including the equal sign. So I guess it should be OK that way.

brammool · 2022-04-17T11:23:49Z

When adding another test I found that this doesn't work:

var x = 'X'
  code =<< eval trim END
    let b = `=x`
  END

This will require more work, since "x" would have to be evaluated at runtime. Let's do that in a followup change.

vim-ml · 2022-04-17T13:39:36Z

Hi Bram,

On Sun, Apr 17, 2022 at 3:51 AM Bram Moolenaar ***@***.***> wrote: I have not seen comments objecting to using the "=expr" form, including the equal sign. So I guess it should be OK that way.

If you think using a single backquote will be easier and less confusing than using "`=", then we can still change this. Regards, Yegappan

errael · 2022-04-17T16:28:19Z

I've never use vimscript, or the = that I see around occasionally. From my perspective, whatever is consistent with what I'll see in vim9script is best; :help script explains vim9. Consistency with vim9 seems paramount. IMO, if the = is required in vim9 in situations, then OK; otherwise nuke it.

brammool · 2022-04-18T14:38:21Z

@cecamp for the highlighting

Problem: Cannot easily mix expression and heredoc. Solution: Support in heredoc. (Yegappan Lakshmanan, closes vim/vim#10138) vim/vim@efbfa86 Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>

yegappan force-pushed the cmdexpand branch 4 times, most recently from c604d73 to 3d5bcb3 Compare April 10, 2022 15:03

yegappan changed the title ~~WIP: Add support for evaluating expression in a heredoc~~ Add support for evaluating expression in a heredoc Apr 10, 2022

yegappan changed the title ~~Add support for evaluating expression in a heredoc~~ Add support for evaluating Vim expressions in a heredoc Apr 10, 2022

yegappan force-pushed the cmdexpand branch 3 times, most recently from 8838a23 to 806fa19 Compare April 11, 2022 02:33

yegappan force-pushed the cmdexpand branch 2 times, most recently from 98ea5a8 to 6b707d2 Compare April 13, 2022 03:47

yegappan force-pushed the cmdexpand branch from 991a2e6 to 50fd646 Compare April 13, 2022 15:20

yegappan force-pushed the cmdexpand branch 6 times, most recently from a43a70f to 5e57b51 Compare April 16, 2022 03:53

Add support for evaluating expression in a heredoc

3d84a66

yegappan force-pushed the cmdexpand branch from 5e57b51 to 3d84a66 Compare April 17, 2022 01:57

brammool closed this in efbfa86 Apr 17, 2022

This comment was marked as off-topic.

Sign in to view

lacygoill mentioned this pull request Apr 28, 2022

unexpected error when using expression in heredoc in skipped block #10306

Closed

LemonBoy mentioned this pull request May 2, 2022

Implement interpolated strings #10327

Closed

vim-ml mentioned this pull request Oct 11, 2022

allow Vim script expressions to be evaluated inside heredocs #10129

Closed

zeertzjq mentioned this pull request Apr 15, 2023

vim-patch:8.2.{4770,4783,4840,4883,4930,4934},9.0.0104: interpolated string neovim/neovim#23105

Merged

Uh oh!

Conversation

yegappan commented Apr 10, 2022

Uh oh!

codecov bot commented Apr 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

brammool commented Apr 10, 2022

Uh oh!

vim-ml commented Apr 10, 2022 via email

Uh oh!

lacygoill commented Apr 11, 2022

Uh oh!

vim-ml commented Apr 11, 2022 via email

Uh oh!

vim-ml commented Apr 11, 2022 via email

Uh oh!

brammool commented Apr 13, 2022

Uh oh!

yegappan commented Apr 13, 2022

Uh oh!

brammool commented Apr 17, 2022

Uh oh!

brammool commented Apr 17, 2022

Uh oh!

vim-ml commented Apr 17, 2022 via email

Uh oh!

errael commented Apr 17, 2022

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

brammool commented Apr 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Apr 10, 2022 •

edited

Loading